Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: ensure images/ exist before creatign files there
Date: Thu, 6 Dec 2018 21:51:54 +0100	[thread overview]
Message-ID: <20181206215154.6587226e@windsurf> (raw)
In-Reply-To: <20181203191219.18998-1-yann.morin.1998@free.fr>

Hello,

On Mon,  3 Dec 2018 20:12:19 +0100, Yann E. MORIN wrote:
> When using an initramfs, on the first-pass build, we create a dummy cpio
> so that the build succeeeds. The real cpio will come later, and we'll do
> a second-pass build to use the actual cpio.
> 
> However, when we touch that dummy cpio, the images/ directory may not
> yet exist, since commit d0f4f95e39 (Makefile: rework main directory
> creation logic) removed its creation at the begining of the build, to
> only at the moment we need it, i.e. during the *_INSTALL_IMAGES_CMDS
> steps.
> 
> However, the linux build is not a _INSTALL_IMAGES_CMDS step, so there is
> no guarantee that images/ already exist at that time.
> 
> Fix that by explicitly creating images/ before touching the dummy cpio.
> 
> Reported-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Matthew Weber <matthew.weber@rockwellcollins.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  linux/linux.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-12-06 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 19:12 [Buildroot] [PATCH] linux: ensure images/ exist before creatign files there Yann E. MORIN
2018-12-03 19:14 ` Matthew Weber
2018-12-06 20:51 ` Thomas Petazzoni [this message]
2018-12-16 15:01 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206215154.6587226e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox