Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] core/sdk: don't mangle symlinks with '.' or '..' at start
Date: Fri, 7 Dec 2018 20:31:05 +0100	[thread overview]
Message-ID: <20181207193105.GI2561@scaer> (raw)
In-Reply-To: <CA+1k=2aNtT59ZjhP_ZiUM6xC52xVCpB=rRWLf02L_LuFB=SRNQ@mail.gmail.com>

Joel, All,

On 2018-12-07 11:08 -0700, Joel Carlson spake thusly:
> On Fri, Dec 7, 2018 at 4:31 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> >     $(patsubst /%,%,$(HOST_DIR))
> I didn't read the documentation on patsubst close enough and didn't
> realize you could make it replace only the first occurrence.  That
> suggestion works and I'll use it.
> 
> > Now, this fixup is not enough, in fact, because thisleaves symlinks to
> > absolute paths borked, e.g.:
[--SNIP--]
> Symlinks with an absolute path is not a case I had considered.
> I will work this further and submit a v2 patch.  Thanks!

Note that I al ready sent a v2 with your patch ammended, and the
absolute symlinks handled:
    https://patchwork.ozlabs.org/project/buildroot/list/?series=80485

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2018-12-07 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  3:50 [Buildroot] [PATCH 1/1] core/sdk: don't mangle symlinks with '.' or '..' at start Joel Carlson
2018-12-07 11:30 ` Yann E. MORIN
2018-12-07 18:08   ` Joel Carlson
2018-12-07 19:31     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207193105.GI2561@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox