From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8
Date: Sat, 8 Dec 2018 22:59:02 +0100 [thread overview]
Message-ID: <20181208215902.GA3383@scaer> (raw)
In-Reply-To: <20181208215231.17886-1-peter@korsgaard.com>
Peter, All,
On 2018-12-08 22:52 +0100, Peter Korsgaard spake thusly:
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, I have a very minor comment, see below...
[--SNIP--]
> diff --git a/configs/minnowboard_max_defconfig b/configs/minnowboard_max_defconfig
> index 9495bf3769..523ddffd51 100644
> --- a/configs/minnowboard_max_defconfig
> +++ b/configs/minnowboard_max_defconfig
> @@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0"
> BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh"
> BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh"
>
> -# Linux headers same as kernel, a 4.14 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
> +# Linux headers same as kernel, a 4.19 series
Do we really need that comment? It is interesting for defconfigs that
use a sha1 from a git tree, for which it is impossible to quickly
identify the kernel version, but here, the kernel version is
human-readable, so we don;t really care about the comment, do we?
Regards,
Yann E. MORIN.
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> # Needed for grub2
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>
> @@ -23,7 +23,7 @@ BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169=y
> # Linux kernel
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8"
> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
>
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-12-08 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 21:52 [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8 Peter Korsgaard
2018-12-08 21:59 ` Yann E. MORIN [this message]
2018-12-08 22:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208215902.GA3383@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox