Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] lua: remove 5.2.x version
Date: Sun, 9 Dec 2018 21:24:08 +0100	[thread overview]
Message-ID: <20181209212408.2a1ecc94@windsurf> (raw)
In-Reply-To: <20181202102506.24699-1-francois.perrad@gadz.org>

Hello,

On Sun,  2 Dec 2018 11:25:06 +0100, Francois Perrad wrote:
> At this time :
> - Lua 5.3.5 will be the last one of its serie.
> - Lua 5.4 is up coming (lua-5.4.0-work2 is already available).
> - Lua 5.2.4 was released on 2015.
> For various reasons in the Lua ecosystem, the Lua 5.1 will stay.
> On BR, Lua 5.3 is the default version since 2016.02.
> 
> So, the serie which could be removed is the 5.2.x.
> We could wait some days for other user feedback.
> 
> Note: see discussion when 5.3.x was introduced : http://lists.busybox.net/pipermail/buildroot/2015-January/117638.html

I've applied, after fixing one small aspect, see below.


> diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
> index 4c5338df0..6d0abaddf 100644
> --- a/package/domoticz/Config.in
> +++ b/package/domoticz/Config.in
> @@ -8,7 +8,7 @@ config BR2_PACKAGE_DOMOTICZ
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
> -	depends on BR2_PACKAGE_LUA_5_2 || BR2_PACKAGE_LUA_5_3
> +	depends on BR2_PACKAGE_LUA_5_3
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
>  	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_BOOST_DATE_TIME
> @@ -35,7 +35,7 @@ comment "domoticz needs lua >= 5.2 and a toolchain w/ C++, gcc >= 4.8, NPTL, wch

You forgot to update this comment: saying lua >= 5.2 no longer makes
sense, so I've updated that to "domoticz needs lua 5.3".

Applied with this change. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-12-09 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-02 10:25 [Buildroot] [PATCH v3 1/1] lua: remove 5.2.x version Francois Perrad
2018-12-03 21:28 ` Thomas Petazzoni
2018-12-04  4:26   ` François Perrad
2018-12-09 20:24 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181209212408.2a1ecc94@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox