From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/tegrarcm: select host-cryptopp and drop BR2_arm dependency
Date: Wed, 12 Dec 2018 09:46:47 +0100 [thread overview]
Message-ID: <20181212094647.57b4149d@windsurf> (raw)
In-Reply-To: <20181212025605.19382-2-casantos@datacom.com.br>
Hello,
On Wed, 12 Dec 2018 00:56:05 -0200, Carlos Santos wrote:
> - It is not be strictly necessary to select host-cryptopp but let's do
> it like other host packages do.
>
> - There is no reason to depend on the target architecture, since it's a
> host tool.
>
> Yes, we could have separate commits to select host-cryptopp and drop
> BR2_arm dependency but that would be overkill.
>
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
> package/tegrarcm/Config.in.host | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/tegrarcm/Config.in.host b/package/tegrarcm/Config.in.host
> index d8cbb947d6..3411501a72 100644
> --- a/package/tegrarcm/Config.in.host
> +++ b/package/tegrarcm/Config.in.host
> @@ -1,6 +1,6 @@
> config BR2_PACKAGE_HOST_TEGRARCM
> bool "host tegrarcm"
> - depends on BR2_arm || BR2_armeb
The idea of this dependency is that since tegracrm is only useful in
conjunction with a Tegra-based system, there is not reason to build it
if the target isn't ARM.
> + select BR2_PACKAGE_HOST_CRYPTOPP
So we are starting to add Config.in.host options for all packages ? Why
are you doing this change ? What is the motivation ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-12 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 2:56 [Buildroot] [PATCH 1/2] package/cryptopp: add Config.in.host Carlos Santos
2018-12-12 2:56 ` [Buildroot] [PATCH 2/2] package/tegrarcm: select host-cryptopp and drop BR2_arm dependency Carlos Santos
2018-12-12 8:46 ` Thomas Petazzoni [this message]
2018-12-12 9:04 ` Arnout Vandecappelle
2018-12-12 9:59 ` Carlos Santos
2018-12-13 19:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212094647.57b4149d@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox