Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] wpa_supplicant - Specify that old and new dbus are incompatible
Date: Sun, 16 Dec 2018 14:10:29 +0100	[thread overview]
Message-ID: <20181216141029.69962524@windsurf.home> (raw)
In-Reply-To: <877eqwjlik.fsf@dell.be.48ers.dk>

Hello,

On Thu, 01 Mar 2018 08:35:47 +0100, Peter Korsgaard wrote:

>  > It generated a .service file with an empty BusName in the [Service] part of 
>  > the .service.
>  > Since enabling only one interface generated the proper file, I deduced both 
>  > could not be enabled together. Maybe something else in my configuration 
>  > impacted that, I will check that again if you can't reproduce.  
> 
> Wait, are we talking about dbus service files (that afaik don't take a
> BusName directive) or systemd files?

I just did a build, with the following defconfig:

BR2_arm=y
BR2_cortex_a8=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y
BR2_INIT_SYSTEMD=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_WPA_SUPPLICANT=y
BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD=y
BR2_PACKAGE_WPA_SUPPLICANT_DBUS_NEW=y
# BR2_TARGET_ROOTFS_TAR is not set

So, it has systemd enabled and both the old and new dbus interfaces in
wpa-supplicant. And the BusName is definitely not empty:

$ cat lib/systemd/system/wpa_supplicant.service 
[Unit]
Description=WPA supplicant
Before=network.target
Wants=network.target

[Service]
Type=dbus
BusName=fi.w1.wpa_supplicant1
ExecStart=/usr/sbin/wpa_supplicant -u

[Install]
WantedBy=multi-user.target
Alias=dbus-fi.w1.wpa_supplicant1.service

Since we haven't heard from the original submitter since February, I'll
mark this patch as Rejected in patchwork.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-12-16 13:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-18 21:50 [Buildroot] [PATCH 1/1] wpa_supplicant - Specify that old and new dbus are incompatible Pierre Ducroquet
2018-02-28 20:38 ` Peter Korsgaard
2018-02-28 22:55   ` Pierre
2018-03-01  7:35     ` Peter Korsgaard
2018-12-16 13:10       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181216141029.69962524@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox