From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 01/14] fftw: breaks fftw-single into a dedicated package
Date: Sun, 16 Dec 2018 21:18:58 +0100 [thread overview]
Message-ID: <20181216211858.1983cbc5@windsurf.home> (raw)
In-Reply-To: <20181212074539.11656-1-gwenj@trabucayre.com>
Hello,
On Wed, 12 Dec 2018 08:45:26 +0100, Gwenhael Goavec-Merou wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> fftw's library name depends on the precision option. Consequently,
> it's possible to install multiple flavor on the same target.
>
> This patch breaks fftw single precision into a new package and:
> - deprecates BR2_PACKAGE_FFTW_PRECISION_SINGLE, BR2_PACKAGE_FFTW_SINGLE must be
> used instead;
> - suppress BR2_PACKAGE_FFTW_USE_SSE and BR2_PACKAGE_FFTW_USE_NEON since options
> are only available on single precision. Corresponding options are directly
> handled in fftw-single package;
> - do fftw depends on fftw-single when this package is enabled.
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
> Changes v1 -> v2:
> * BR2_PACKAGE_FFTW_PRECISION_SINGLE -> BR2_PACKAGE_FFTW_SINGLE (Arnout)
> * old symbol deprecation (Arnout)
> * split big monolithic patch into a serie (Arnout)
> * add dependency between fftw and fftw-single (Yann)
> ---
> Config.in.legacy | 9 +++++++
> package/fftw/Config.in | 17 ++----------
> package/fftw/fftw-single/Config.in | 5 ++++
> package/fftw/fftw-single/fftw-single.hash | 1 +
> package/fftw/fftw-single/fftw-single.mk | 33 +++++++++++++++++++++++
> package/fftw/fftw.mk | 12 ++++-----
> 6 files changed, 56 insertions(+), 21 deletions(-)
> create mode 100644 package/fftw/fftw-single/Config.in
> create mode 120000 package/fftw/fftw-single/fftw-single.hash
> create mode 100644 package/fftw/fftw-single/fftw-single.mk
For information: Yann and me have started reviewing/testing/tweaking
this patch series today. We found a number of things to improve, and
I'll continue working on this.
So I'd be nice if Arnout/Peter you could wait before applying this, and
consider it is in my queue of patches to apply. I'll mark the patches
as delegated to me.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-16 20:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 7:45 [Buildroot] [PATCH v2 01/14] fftw: breaks fftw-single into a dedicated package Gwenhael Goavec-Merou
2018-12-12 7:45 ` [Buildroot] [PATCH v2 02/14] fftw: breaks fftw-long-double " Gwenhael Goavec-Merou
2018-12-12 19:18 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 03/14] fftw: breaks fftw-quad " Gwenhael Goavec-Merou
2018-12-12 19:21 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 04/14] fftw: breaks fftw-double " Gwenhael Goavec-Merou
2018-12-12 19:22 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 05/14] alsa-utils: update DEPENDENCIES to fftw-single Gwenhael Goavec-Merou
2018-12-12 19:25 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 06/14] aubio: update DEPENDENCIES to ffw-single or fftw-double depending on enabled option Gwenhael Goavec-Merou
2018-12-12 19:26 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 07/14] gnuradio: change depend to select for fftw and use fftw-single in DEPENDENCIES Gwenhael Goavec-Merou
2018-12-12 19:28 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 08/14] gqrx: suppress fft depend since fft's precision is selected by gnuradio Gwenhael Goavec-Merou
2018-12-12 19:31 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 09/14] use select instead of depend for fftw package and fix DEPENDENCIES Gwenhael Goavec-Merou
2018-12-12 19:33 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 10/14] httping: update package to use new fftw structure Gwenhael Goavec-Merou
2018-12-12 19:33 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 11/14] imagemagick: reference explicitly fftw double Gwenhael Goavec-Merou
2018-12-12 19:34 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 12/14] libvips: " Gwenhael Goavec-Merou
2018-12-12 19:35 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 13/14] pulseaudio: update dependency to fftw-single Gwenhael Goavec-Merou
2018-12-12 19:36 ` Joel Carlson
2018-12-12 7:45 ` [Buildroot] [PATCH v2 14/14] liquid-dsp: update package to use new fftw structure Gwenhael Goavec-Merou
2018-12-12 19:37 ` Joel Carlson
2018-12-12 19:17 ` [Buildroot] [PATCH v2 01/14] fftw: breaks fftw-single into a dedicated package Joel Carlson
2018-12-16 20:18 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216211858.1983cbc5@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox