From: Carlos Santos <casantos@datacom.com.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] [RFC] package/pkg-waf.mk: mimic selection of host-waf
Date: Thu, 20 Dec 2018 22:22:21 -0200 [thread overview]
Message-ID: <20181221002221.16024-2-casantos@datacom.com.br> (raw)
In-Reply-To: <20181221002221.16024-1-casantos@datacom.com.br>
Since host-waf's Config.in.host is blind, it is not possible to select
it in the configuration menu. There are two possible solutions for this
problem:
- Add "select BR2_PACKAGE_HOST_WAF" to package/mpv/Config.in (currently
only mpv requires host-waf). Also, document that BR2_PACKAGE_HOST_WAF
must be selected when <PKG>_NEEDS_EXTERNAL_WAF is YES.
- Set BR2_PACKAGE_HOST_WAF to 'y' in the waf-package macro. This one is
simpler because it does not require changing anything else.
Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
package/pkg-waf.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk
index 3288dd63a0..fe5995250c 100644
--- a/package/pkg-waf.mk
+++ b/package/pkg-waf.mk
@@ -43,6 +43,7 @@ $(2)_NEEDS_EXTERNAL_WAF ?= NO
# If the package does not have its own waf, use our own.
ifeq ($$($(2)_NEEDS_EXTERNAL_WAF),YES)
+BR2_PACKAGE_HOST_WAF = y
$(2)_DEPENDENCIES += host-waf
$(2)_WAF = $$(HOST_DIR)/bin/waf
else
--
2.19.2
next prev parent reply other threads:[~2018-12-21 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 0:22 [Buildroot] [PATCH v2 1/2] package/waf: add a blind Config.in.host Carlos Santos
2018-12-21 0:22 ` Carlos Santos [this message]
2018-12-21 15:34 ` [Buildroot] [PATCH v2 2/2] [RFC] package/pkg-waf.mk: mimic selection of host-waf Thomas Petazzoni
2018-12-21 16:04 ` Carlos Santos
2018-12-21 19:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221002221.16024-2-casantos@datacom.com.br \
--to=casantos@datacom.com.br \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox