From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] iptables: add patch to fix symlink path of iptables-xml
Date: Sat, 22 Dec 2018 08:04:55 +0100 [thread overview]
Message-ID: <20181222080455.6419ae8c@windsurf.home> (raw)
In-Reply-To: <20181221232959.27895-1-JoelsonCarl@gmail.com>
Hello,
On Fri, 21 Dec 2018 16:29:59 -0700, Joel Carlson wrote:
> +diff --git a/iptables/Makefile.am b/iptables/Makefile.am
> +index f92cc4ff..fe5195d7 100644
> +--- a/iptables/Makefile.am
> ++++ b/iptables/Makefile.am
> +@@ -88,7 +88,7 @@ pkgconfig_DATA = xtables.pc
> + install-exec-hook:
> + -if test -z "${DESTDIR}"; then /sbin/ldconfig; fi;
> + ${INSTALL} -dm0755 "${DESTDIR}${bindir}";
> +- for i in ${vx_bin_links}; do ${LN_S} -f "${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;
> ++ for i in ${vx_bin_links}; do ${LN_S} -f "${DESTDIR}${sbindir}/xtables-multi" "${DESTDIR}${bindir}/$$i"; done;
For the target installation, this looks wrong. It means you would have
on the target a link that points
to /the/original/path/to/where/buildroot/was/built/output/target/sbin/xtables-multi.
Doesn't sound good.
A relative symlink instead would fix the problem.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-22 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 23:29 [Buildroot] [PATCH 1/1] iptables: add patch to fix symlink path of iptables-xml Joel Carlson
2018-12-22 7:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222080455.6419ae8c@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox