Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boot/uboot: add support for custom DT name
Date: Mon, 24 Dec 2018 14:47:59 +0100	[thread overview]
Message-ID: <20181224144759.283fe055@windsurf.home> (raw)
In-Reply-To: <20181224131904.20891-1-kostap@marvell.com>

Hello Kostya,

+Clemens Gruber in Cc, who posted a related U-Boot patch.

On Mon, 24 Dec 2018 15:19:04 +0200, kostap at marvell.com wrote:
> From: Konstantin Porotchkin <kostap@marvell.com>
> 
> Some u-boot default configuration files could be shared between
> targets and used for building images for multiple board types.
> The only difference between such builds is the DTB embedded in
> in the boot image for each specific platform.
> This approach is widely used by Marvell, having the same u-boot
> configuration file for the entire SoC family, but allowing builds
> of multiple target flavors by supplying the device tree name through
> make command parameter DEVICE_TREE=xxx
> This patch adds such capability to uboot module of the buildroot.
> The custome DT name could be  defined by
> BR2_TARGET_UBOOT_CUSTOM_DTS_NAME entry.
> 
> Change-Id: I69e193339b0369a736bdf98491b9914d24a54e17
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>

Reading this again, in fact it is very similar to patch
http://patchwork.ozlabs.org/patch/881197/ we already have in the queue.
With a very important distinction: your patch passes DEVICE_TREE=,
while the existing pending patch passes EXT_DTB=. The obvious question
that comes up is: which one is right ? Or are these two orthogonal
things ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-24 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 13:19 [Buildroot] [PATCH] boot/uboot: add support for custom DT name kostap at marvell.com
2018-12-24 13:47 ` Thomas Petazzoni [this message]
2018-12-24 13:56   ` [Buildroot] [EXT] " Kostya Porotchkin
2018-12-24 16:59   ` [Buildroot] " Clemens Gruber
2019-02-03 19:49     ` Thomas Petazzoni
2019-02-15 15:04       ` Clemens Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181224144759.283fe055@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox