Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/solarus: bump to version 1.6.0
Date: Wed, 26 Dec 2018 21:33:58 +0100	[thread overview]
Message-ID: <20181226213358.01ef170c@windsurf.home> (raw)
In-Reply-To: <20181223133317.3490-1-romain.naour@gmail.com>

Hello Romain,

On Sun, 23 Dec 2018 14:33:17 +0100, Romain Naour wrote:
> Here are the big features in Solarus 1.6:
> 
>     * OpenGL backend and support for GLSL shaders (by Stdgregwar and Vlag)

I am a bit confused because this OpenGL dependency now seems to be
mandatory, but you don't make it mandatory.

cmake/AddDependencies.cmake contains:

find_package(OpenGL)
if(NOT OPENGL_FOUND)
  find_package(OpenGLES2 REQUIRED)
endif()

So it seems like it wants either OpenGL or OpenGL ES2, no?

In any case, if it's really not mandatory, passing the appropriate
-D<blah>=OFF to explicitly disable OpenGL support would be good.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-26 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23 13:33 [Buildroot] [PATCH] package/solarus: bump to version 1.6.0 Romain Naour
2018-12-26 20:33 ` Thomas Petazzoni [this message]
2018-12-28 15:25   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181226213358.01ef170c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox