From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v3] core: make symlinks relative when preparing the SDK
Date: Wed, 26 Dec 2018 22:21:35 +0100 [thread overview]
Message-ID: <20181226222135.4ef03363@windsurf> (raw)
In-Reply-To: <9f4825baa7a475b4d8f262925e1ff652b31cd6fb.1545491919.git.yann.morin.1998@free.fr>
Hello,
On Sat, 22 Dec 2018 16:18:51 +0100, Yann E. MORIN wrote:
> The SDK is supposed to be relocatable, so symlinks must not be
> absolute.
>
> Add a new helper script, that replaces all absolute symlinks with
> relative ones.
This script is really not trivial. This additional complexity raises a
simple question: how many packages install such absolute symlinks?
Should we instead detect such absolute symlinks, and use that to fix
the problematic packages ?
I am not saying at all that the approach of fixing all symlinks is
wrong, but I'd like to see a proper discussion on the balance between
fixing the problematic packages vs. taking the "brutal" approach of
this new fix-symlinks script.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-26 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 15:18 [Buildroot] [PATCH 0/2 v3] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk) Yann E. MORIN
2018-12-22 15:18 ` [Buildroot] [PATCH 1/2 v3] core: make symlinks relative when preparing the SDK Yann E. MORIN
2018-12-26 21:21 ` Thomas Petazzoni [this message]
2019-01-05 0:53 ` Joel Carlson
2019-01-09 13:27 ` Andreas Naumann
2018-12-22 15:18 ` [Buildroot] [PATCH 2/2 v3] core/sdk: don't mangle symlinks with '.' or '..' at start Yann E. MORIN
2019-02-06 15:28 ` Arnout Vandecappelle
2019-02-19 7:29 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226222135.4ef03363@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox