From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
Date: Sat, 29 Dec 2018 10:44:44 +0100 [thread overview]
Message-ID: <20181229104444.432615e2@windsurf> (raw)
In-Reply-To: <CA+h8R2q+H=kpewLO2q2zbxMWGJ8AaznRVd4xnn-jXbjf-q9jQw@mail.gmail.com>
Hello,
On Fri, 28 Dec 2018 20:46:50 -0800, Christian Stewart wrote:
> On Fri, Dec 28, 2018 at 7:07 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > When libsseccomp support is enabled, docker-containerd uses pkg-config
> > to find libsseccomp, so we must depend on host-pkconf.
> > +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
>
> LGTM.
Thanks for the review.
> Signed-off-by: Christian Stewart <christian@paral.in>
>
> - I hope signed-off-by is appropriate here.
Signed-off-by is when you're the author, or in the chain of
developers/maintainers that carry the patch all the way to upstream.
In this case, what you should ideally have used is a Acked-by or
Reviewed-by. See also
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-29 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 15:07 [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf Thomas Petazzoni
2018-12-29 4:46 ` Christian Stewart
2018-12-29 9:44 ` Thomas Petazzoni [this message]
2018-12-29 10:29 ` Yann E. MORIN
2018-12-29 10:43 ` Christian Stewart
2018-12-30 15:57 ` Thomas Petazzoni
2019-01-18 15:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229104444.432615e2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox