From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package
Date: Sun, 30 Dec 2018 22:50:06 +0100 [thread overview]
Message-ID: <20181230225006.157b6c31@windsurf> (raw)
In-Reply-To: <CADvTj4pp1AXkige=X5PKOyPk01daPkHyjA194GQYRSQPnu=SGw@mail.gmail.com>
Hello James,
On Sun, 30 Dec 2018 15:38:02 -0600, James Hilliard wrote:
> Yeah, I didn't do that for these since I was adding these packages
> only since they were required for the luaposix version bump, I also
> don't normally write anything in lua(I'm primarily a python developer)
> but needed to use lua for the built in script interface in the
> swupdate package for automatic disk formatting and installation.
OK, understood. But by default, we expect people who add new packages
to be willing to take care of them, at least to some extent.
> > This dependency is not needed: all Lua modules inclusions in
> > package/Config.in are already enclosed in a
> > BR2_PACKAGE_HAS_LUAINTERPRETER & !BR2_STATIC_LIBS condition.
> Yeah, I wasn't sure what was supposed to be there, I copied that from luaposix.
A number of other Lua packages have this redundant dependency. I have
sent a patch to remove it: http://patchwork.ozlabs.org/patch/1019425/.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-30 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 2:07 [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package james.hilliard1 at gmail.com
2018-12-29 2:07 ` [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: " james.hilliard1 at gmail.com
2018-12-29 8:16 ` François Perrad
2018-12-30 14:07 ` Thomas Petazzoni
2018-12-29 2:07 ` [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4 james.hilliard1 at gmail.com
2018-12-29 8:16 ` François Perrad
2018-12-29 8:15 ` [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package François Perrad
2018-12-30 13:53 ` Thomas Petazzoni
2018-12-30 21:38 ` James Hilliard
2018-12-30 21:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230225006.157b6c31@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox