Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 2/3] wpebackend-fdo: new package
Date: Mon, 31 Dec 2018 15:02:05 +0100	[thread overview]
Message-ID: <20181231150205.2a68a09b@windsurf> (raw)
In-Reply-To: <20181228015802.GF19602@momiji>

Hello Adrian,

Thanks for the review!

On Fri, 28 Dec 2018 01:58:02 +0100, Adrian Perez de Castro wrote:

> > diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in
> > new file mode 100644
> > index 000000000..9025834e1
> > --- /dev/null
> > +++ b/package/wpebackend-fdo/Config.in
> > @@ -0,0 +1,17 @@
> > +comment "wpebackend-fdo needs an OpenEGL-capable backend"
> > +	depends on !BR2_PACKAGE_HAS_LIBEGL
> > +  
> 
> The dependency line for the comment needs to be updated to be the reverse
> of the list of dependencies for the BR2_PACKAGE_WPEBACKEND_FDO symbol below.
> 
> Also, the comment text should follow the Buildroot style:
> 
>     foo needs a toolchain w/ featA, featB, featC

Actually this form applies to toolchain features. For something like
OpenGL, we do use a comment similar to what Fran?ois has used. See:

$ git grep "comment.*OpenGL"

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-12-31 14:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23 15:48 [Buildroot] [RFC 0/3] WPE WebKit Francois Perrad
2018-12-23 15:48 ` [Buildroot] [RFC 1/3] libwpe: new package Francois Perrad
2018-12-28  0:47   ` Adrian Perez de Castro
2018-12-23 15:48 ` [Buildroot] [RFC 2/3] wpebackend-fdo: " Francois Perrad
2018-12-28  0:58   ` Adrian Perez de Castro
2018-12-29  9:15     ` François Perrad
2018-12-31 14:02     ` Thomas Petazzoni [this message]
2018-12-23 15:48 ` [Buildroot] [RFC 3/3] wpewebkit: " Francois Perrad
2018-12-28  1:18   ` Adrian Perez de Castro
2018-12-29  9:28     ` François Perrad
2018-12-31 14:08     ` Thomas Petazzoni
2018-12-27  9:30 ` [Buildroot] [RFC 0/3] WPE WebKit Thomas Petazzoni
2018-12-28  0:34 ` Adrian Perez de Castro
2018-12-30 18:01   ` François Perrad
2018-12-31 14:13   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231150205.2a68a09b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox