From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/dependencies: require at least CMake 3.8
Date: Mon, 31 Dec 2018 18:18:49 +0100 [thread overview]
Message-ID: <20181231171849.GC26917@scaer> (raw)
In-Reply-To: <20181231170014.GB26917@scaer>
On 2018-12-31 18:00 +0100, Yann E. MORIN spake thusly:
> On 2018-12-31 17:47 +0100, Thomas Petazzoni spake thusly:
> > On Mon, 31 Dec 2018 17:44:54 +0100, Yann E. MORIN wrote:
> > > On 2018-12-31 17:26 +0100, Thomas Petazzoni spake thusly:
> > > > The json-for-modern-cpp package unfortunately now requires CMake >=
> > > > 3.8, so we need to bump our requirement from 3.1 to 3.8. If the host
> > > > doesn't have a CMake >= 3.8, Buildroot will build its own host-cmake
> > > > package.
> > >
> > > The upstream commit that bumped the requirement to cmake 3.8 states:
> > >
> > > Using target_compile_features to specify C++ 11 standard
> > > https://github.com/nlohmann/json/commit/73cc5089e33ea950b6677e19ee7ec656c9bcf985
> > >
> > > However, target_compile_features has been available even since 3.1 at
> > > least:
> > >
> > > https://cmake.org/cmake/help/v3.1/command/target_compile_features.html
> > >
> > > I'll kick-start a build with a patched json-for-modern-cpp, to see if we
> > > can stay on 3.1.
> > Thanks! It would be a lot nicer! Do you have a CMake 3.1 installation
> > readily available ?
> Now I have! ;-)
And indeed, that is sufficient to stick to 3.1. I'll send a proper patch
and submit it upstream too.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-12-31 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 16:26 [Buildroot] [PATCH] support/dependencies: require at least CMake 3.8 Thomas Petazzoni
2018-12-31 16:44 ` Yann E. MORIN
2018-12-31 16:47 ` Thomas Petazzoni
2018-12-31 17:00 ` Yann E. MORIN
2018-12-31 17:18 ` Yann E. MORIN [this message]
2018-12-31 17:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181231171849.GC26917@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox