Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Revert "utils/get-developers: make it callable from elsewhere than the toplevel directory"
Date: Thu,  3 Jan 2019 11:56:55 +0100	[thread overview]
Message-ID: <20190103105657.23751-1-peter@korsgaard.com> (raw)

This reverts commit 62d5558f76a790d1c1b3a1834f1736dc86b6e34f.

This actually does not work, as patches contain paths relative to the
toplevel directory as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 utils/get-developers     | 6 ++----
 utils/getdeveloperlib.py | 2 --
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/utils/get-developers b/utils/get-developers
index c887938859..ce882e6699 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -24,9 +24,7 @@ def parse_args():
 
 
 def __main__():
-    # DEVELOPERS is one level up from here
-    devs_dir = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..')
-    devs = getdeveloperlib.parse_developers(devs_dir)
+    devs = getdeveloperlib.parse_developers()
     if devs is None:
         sys.exit(1)
     args = parse_args()
@@ -52,7 +50,7 @@ def __main__():
 
     # Handle the check action
     if args.check:
-        files = getdeveloperlib.check_developers(devs, devs_dir)
+        files = getdeveloperlib.check_developers(devs)
         for f in files:
             print(f)
 
diff --git a/utils/getdeveloperlib.py b/utils/getdeveloperlib.py
index 84665520c6..2c8d477583 100644
--- a/utils/getdeveloperlib.py
+++ b/utils/getdeveloperlib.py
@@ -158,8 +158,6 @@ def parse_developers(basepath=None):
     linen = 0
     if basepath is None:
         basepath = os.getcwd()
-    else:
-        basepath = os.path.abspath(basepath)
     with open(os.path.join(basepath, "DEVELOPERS"), "r") as f:
         files = []
         name = None
-- 
2.11.0

             reply	other threads:[~2019-01-03 10:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 10:56 Peter Korsgaard [this message]
2019-01-03 10:56 ` [Buildroot] [PATCH 2/2] utils/get-developers: really make it callable from elsewhere than the toplevel directory Peter Korsgaard
2019-01-04 12:24   ` Peter Korsgaard
2019-01-24 10:59   ` Peter Korsgaard
2019-01-04 12:24 ` [Buildroot] [PATCH 1/2] Revert "utils/get-developers: make it callable from elsewhere than the toplevel directory" Peter Korsgaard
2019-01-24 10:59 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103105657.23751-1-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox