From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] support/scripts/pkg-stats: add latest upstream version information
Date: Thu, 3 Jan 2019 17:28:59 +0100 [thread overview]
Message-ID: <20190103172859.26441562@windsurf> (raw)
In-Reply-To: <CANQCQpaRYaQqob=i_H+vzJLa+tkQmnfPA1JDjKi5gTuaPaHyEA@mail.gmail.com>
Hello,
Thanks for the testing!
On Thu, 3 Jan 2019 10:19:08 -0600, Matthew Weber wrote:
> > +def release_monitoring_get_latest_version_by_distro(name):
> > + try:
> > + req = requests.get(os.path.join(RELEASE_MONITORING_API, "project", "Buildroot", name))
>
> I noticed this was required during testing. I'm not sure if it was my
> proxy, python version or a certificate issue on their end. I had to
> disable ssl verification as the release monitoring site redirects to
> https when you access it and the cert check fails.
>
> req = requests.get(os.path.join(RELEASE_MONITORING_API, "project",
> "Buildroot", name), verify=False)
Weird, it was working fine here. However, in the v5, I'm using
HTTPSConnectionPool(), and I properly handled (I think!) the
certificate stuff.
> With this patch, I generated the following. Nothing looks like it was
> incorrect at first glance....
> https://rc-matthew-l-weber.github.io/misc/stats.html
Well, nothing was visibly wrong: in the v4, when there is an exception
when doing a requests.get(), the code returns (False, None, None),
which is the same as "not result was found". So basically, the result
"Not found" in the "Last version" column could mean that the HTTP
request failed.
In the v5, I've implemented proper error handling, so that in the
results we can make the difference between "no result was found" and
"something when wrong when retrieving the results".
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-01-03 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 17:17 [Buildroot] [PATCH v4] support/scripts/pkg-stats: add latest upstream version information Thomas Petazzoni
[not found] ` <CANQCQpaRYaQqob=i_H+vzJLa+tkQmnfPA1JDjKi5gTuaPaHyEA@mail.gmail.com>
2019-01-03 16:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103172859.26441562@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox