From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] test-pkg: Force checking dependencies.
Date: Thu, 3 Jan 2019 18:07:30 +0100 [thread overview]
Message-ID: <20190103180730.40579a47@windsurf> (raw)
In-Reply-To: <20190102154920.116641-1-aduskett@gmail.com>
Hello,
On Wed, 2 Jan 2019 10:49:20 -0500, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Currently, if a user runs "make" while specifying a specific package
> (IE: make -p foo), the Makefile logic skips checking to see if all the
> dependencies are selected in the specified packages config file. This behavior
> is useful to test simple packages which do not have "complex" dependencies.
>
> However; if a developer uses test-pkg -p ${package_name} to check their package,
> the package may pass all the checks, but would have otherwise failed with a
> simple "make" because the developer may have failed to add a select line in
> packages config file, even if there is a new dependency in the packages
> Makefile.
>
> Pass the environment variable "BR_FORCE_CHECK_DEPENDENCIES" to the Makefile in
> the test-pkg script, and check it's value in the Makefile. If the value is
> "YES" force checking for dependency issues.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v1 -> v2:
> - Change FORCE_CHECK_DEPENDENCIES to BR_FORCE_CHECK_DEPENDENCIES (Thomas)
> - Only set BR_FORCE_CHECK_DEPENDENCIES=YES on line 155 of test-pkg (Yann)
Applied to master, thanks. Note: for the commit title, please use
"utils/test-pkg" for the prefix, and don't use an uppercase letter
after the prefix. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-01-03 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 15:49 [Buildroot] [PATCH v2 1/1] test-pkg: Force checking dependencies aduskett at gmail.com
2019-01-02 17:00 ` Yann E. MORIN
2019-01-03 17:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103180730.40579a47@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox