From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] support/scripts/pkg-stats: add latest upstream version information
Date: Thu, 3 Jan 2019 21:38:37 +0100 [thread overview]
Message-ID: <20190103203837.GA5991@scaer> (raw)
In-Reply-To: <CA+fik52n+izpqRGSSP1QFMoPCCd1y0Mub714-1cHWFYotXuhNg@mail.gmail.com>
Brandon, All,
On 2019-01-03 13:57 -0600, Brandon Maier spake thusly:
> This is a useful tool, thanks! I don't have time to test it right now,
> but an observation.
>
> On Thu, Jan 3, 2019 at 2:38 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> ...
> > + elif pkg.latest_version[1] == pkg.current_version:
> > + stats["version-uptodate"] += 1
> ...
> > + elif pkg.latest_version[1] != pkg.current_version:
> > + td_class.append("version-needs-update")
>
> From https://bootlin.com/~thomas/stats.html, there's a few packages
> that are up-to-date, but get marked "version-needs-update" because
> either the Buildroot or release-monitoring version string starts with
> a "v".
There was an issue raised (long ago) about this in the anitya tool
(which generatees the DB at r-m.o):
https://github.com/release-monitoring/anitya/issues/374
So, the version strings we get from r-m.o should no longer have a
leading 'v' anymore.
Yet, in our FOO_VERSION, we in Buildroot may still have those leading
'v'. So, we should try to compare the versions as-is, and then remove
out leading 'v' and compare again. ot sure of the exact heuristic,
though...
Regards,
Yann E. MORIN.
> For example, the vmtouch and libmodbus packages. It would be
> nice to change the version comparison to ignore a leading "v". E.g.
>
> def version_uptodate(pkg):
> latest = remove_prefix(pkg.latest_version[1], 'v')
> current = remove_prefix(pkg.current_version, 'v')
> return latest == current
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-01-03 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 8:38 [Buildroot] [PATCH v5] support/scripts/pkg-stats: add latest upstream version information Thomas Petazzoni
2019-01-03 8:40 ` Thomas Petazzoni
2019-01-03 19:57 ` Brandon Maier
2019-01-03 20:33 ` Thomas Petazzoni
2019-01-03 21:02 ` [Buildroot] [External] " Brandon Maier
2019-01-03 21:16 ` Thomas Petazzoni
2019-01-03 23:29 ` Brandon Maier
2019-01-03 20:38 ` Yann E. MORIN [this message]
[not found] ` <CANQCQpZHYrkUVrYUxqANd9xzicMz-9apDWYeUWYmHLqG6YA8wg@mail.gmail.com>
2019-01-03 20:23 ` [Buildroot] [External] " Matthew Weber
2019-01-04 2:12 ` [Buildroot] " Ricardo Martincoski
2019-01-04 14:54 ` Brandon Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103203837.GA5991@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox