Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/systemd: set vconsole support option to default y
Date: Sat, 5 Jan 2019 14:40:47 +0100	[thread overview]
Message-ID: <20190105144047.552d69d7@windsurf> (raw)
In-Reply-To: <1dc021862b1041c3990d6ce25bb331ca@exitstrategytech.com>

Hello David,

Thanks for this contribution!

On Fri, 4 Jan 2019 21:35:23 +0000, David J. Fogle wrote:
> package/systemd:? set vconsole support option to default y

There is no need to repeat the commit title twice.

> Without this support option enabled, systemd does not allow vterm switching, and could possibly lead to user lockout on tty1. 
> 
> We prevent these scenarios by enabling the vconsole tool default y, as console login is much more prevalent than not.

I am not sure why you say "much more prevalent than not". I would say
quite the opposite: in embedded systems, either there is no screen at
all, or when there is a screen, it is used to display an end-user
application and not a console login.

> This allows the option to disable the tool if needed, but as this is a
> rare usage, it is better to let a user decide they do *not* need it
> than to expect them to know they *do*.

I'm a bit unconvinced. What is the size impact of having this option
enabled by default ?

Also, make sure your commit log is wrapped to 72 characters.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-01-05 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 21:35 [Buildroot] [PATCH] package/systemd: set vconsole support option to default y David J. Fogle
2019-01-05 13:40 ` Thomas Petazzoni [this message]
2019-02-06 13:16 ` Thomas Petazzoni
2019-02-18 22:26   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190105144047.552d69d7@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox