From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/19] infra/pkg-generic: only list files installed by the current package
Date: Tue, 8 Jan 2019 17:08:20 +0100 [thread overview]
Message-ID: <20190108160820.GI19623@scaer> (raw)
In-Reply-To: <CAAXf6LUYuoi3Ws=kCvf-Yj-r+eWLFY217tuEHRbY_+YgJ_zbqA@mail.gmail.com>
Thomas DS, All,
Thanks for the review! :-)
On 2019-01-08 14:07 +0100, Thomas De Schampheleire spake thusly:
> El lun., 7 ene. 2019 a las 23:05, Yann E. MORIN
> (<yann.morin.1998@free.fr>) escribi?:
snip
> > We fix that by limiting the search for files that have been actually
> > touched during the install step, now that we have the proper timestamp
> > for it.
[--SNIP--]
> > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> > index 3de8a99675..42aebeb49d 100644
> > --- a/package/pkg-generic.mk
> > +++ b/package/pkg-generic.mk
> > @@ -67,7 +67,7 @@ define step_pkg_size_inner
> > $(SED) '/^$(1),/d' $(BUILD_DIR)/packages-file-list$(3).txt
> > cd $(2); \
> > find . \( -type f -o -type l \) \
> > - -newer $($(PKG)_DIR)/.stamp_built \
> > + -newer $@_before \
> While it is probably not important, just noting here that if package A
> installs a file with a modification time in the future, then package B
> installed after A would still get that future file in its list. In
> fact, every package built after pkg A would then get that file into
> 'its' list.
How is this different from the current situation?
Maybe in that case, it would make sense that we touch all files after a
package installation (limited to that package's files, of course)?
My position is that, if a package voluntarily install stuff in the
future, it is borked. I.e. either it uses an absolute time, in which
case that time will be in the past some time in the future, or it uses
a delta, in which case it is not reproducible.
Furthermore when we do an actual reproducible build, we actually touch
all files at the end of the build, so a package that relies on file's
timestamp is not reproducible.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-01-08 16:08 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 22:05 [Buildroot] [PATCH 00/19] support: limit install-time instrumentation to current package's files (branch yem/files-list-2) Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 01/19] infra/pkg-generic: display MESSAGE before running PRE_HOOKS Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 02/19] infra/pkg-generic: create $(@D) " Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 03/19] infra/pkg-generic: introduce new stampfile at the beginning of all steps Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 04/19] infra/pkg-generic: use \0 to separate .la files as they are found Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 05/19] infra/pkg-generic: tweak only .la files installed by the current package Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 06/19] infra/pkg-generic: only list " Yann E. MORIN
2019-01-08 13:07 ` Thomas De Schampheleire
2019-01-08 15:56 ` Thomas De Schampheleire
2019-01-08 19:51 ` Yann E. MORIN
2019-01-08 16:08 ` Yann E. MORIN [this message]
2019-01-08 16:55 ` Thomas De Schampheleire
2019-01-08 20:02 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 07/19] infra/pkg-generic: offload same-package filtering to check-uniq-file Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 08/19] support/check-uniq-files: decode as many strings as possible Yann E. MORIN
2019-02-07 23:40 ` Arnout Vandecappelle
2019-02-08 17:25 ` Yann E. MORIN
2019-02-08 20:42 ` Arnout Vandecappelle
2019-02-08 21:22 ` Yann E. MORIN
2019-02-08 22:02 ` Arnout Vandecappelle
2019-01-07 22:05 ` [Buildroot] [PATCH 09/19] support: add parser in python for packages-file-list files Yann E. MORIN
2019-01-08 13:35 ` Thomas De Schampheleire
2019-01-08 16:29 ` Yann E. MORIN
2019-01-08 17:30 ` Thomas De Schampheleire
2019-01-08 20:52 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 10/19] support: rewrite check-bin-arch in python Yann E. MORIN
2019-01-08 14:56 ` Thomas De Schampheleire
2019-01-08 16:37 ` Yann E. MORIN
2019-01-08 17:22 ` Thomas De Schampheleire
2019-01-08 20:33 ` Yann E. MORIN
2019-01-08 20:46 ` Thomas De Schampheleire
2019-01-08 21:16 ` Yann E. MORIN
2019-01-09 14:47 ` Thomas De Schampheleire
2019-01-07 22:05 ` [Buildroot] [PATCH 11/19] support: introduce new format for packages-file-list files Yann E. MORIN
2019-01-08 15:07 ` Thomas De Schampheleire
2019-01-08 19:27 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 12/19] infra/pkg-generic: store md5 of just-installed files Yann E. MORIN
2019-01-08 15:13 ` Thomas De Schampheleire
2019-01-08 19:31 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 13/19] support/check-uniq-file: invert condition logic Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 14/19] support/check-uniq-files: don't report files of the same content Yann E. MORIN
2019-01-08 15:22 ` Thomas De Schampheleire
2019-01-07 22:05 ` [Buildroot] [PATCH 15/19] support/check-uniq-files: use argparse to enfore required options Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 16/19] core: check unique files in the corresponding finalize step Yann E. MORIN
2019-01-08 15:24 ` Thomas De Schampheleire
2019-01-08 19:36 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 17/19] core: check for unique target files after all our cleanups Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 18/19] core: ignore non-unique files that have disapeared Yann E. MORIN
2019-01-08 15:29 ` Thomas De Schampheleire
2019-01-08 19:44 ` Yann E. MORIN
2019-01-07 22:05 ` [Buildroot] [PATCH 19/19] core: add optional failure when 2+ packages touch the same file Yann E. MORIN
2019-01-08 12:51 ` [Buildroot] [PATCH 00/19] support: limit install-time instrumentation to current package's files (branch yem/files-list-2) Thomas De Schampheleire
2019-01-08 15:53 ` Thomas De Schampheleire
2019-01-08 21:30 ` Yann E. MORIN
2019-01-09 13:39 ` Thomas De Schampheleire
2019-01-09 18:10 ` Yann E. MORIN
2019-01-10 20:34 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108160820.GI19623@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox