From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] libinput: drop C++ dependency
Date: Sat, 12 Jan 2019 08:33:21 +0100 [thread overview]
Message-ID: <20190112073321.GE2428@scaer> (raw)
In-Reply-To: <20190111230158.5283-1-ps.report@gmx.net>
Peter, All,
On 2019-01-12 00:01 +0100, Peter Seiderer spake thusly:
> The meson C++ dependency is only used for a build-time header
> include test, so drop both.
[--SNIP--]
> [1] http://autobuild.buildroot.net/results/bf4d3d360f635c3524a52b84a72d558770596ed0
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Note:
> - alternative solution would be to add a c++ dependency for libinput
> - patch could be improved to optional C++ dependency/compile (but did
> not know how to express this in meson)
[--SNIP--]
> +@@ -641,12 +641,6 @@ executable('test-build-linker',
> + include_directories : [includes_src, includes_include],
> + dependencies : [ dep_libinput, dep_libinput_util ],
> + install : false)
> +-# test including from C++
> +-executable('test-build-cxx',
> +- 'test/build-cxx.cc',
> +- dependencies : [dep_udev],
> +- include_directories : [includes_src, includes_include],
> +- install : false)
You may want to test something like that:
if add_languages('cpp')
executable('test-build-cxx',
blablabla)
endif
If that works, then I think I'd prefer we use this patch, because it is
upstreamable, which you should try to do btw.
Regards,
Yann E. MORIN.
> + # This is the test suite runner, we allow disabling that one because of
> + # dependencies
> +--
> +2.20.1
> +
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-01-12 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 23:01 [Buildroot] [PATCH v1] libinput: drop C++ dependency Peter Seiderer
2019-01-12 7:33 ` Yann E. MORIN [this message]
2019-01-12 9:44 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112073321.GE2428@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox