Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mesa3d: override dri path
Date: Mon, 14 Jan 2019 22:31:33 +0100	[thread overview]
Message-ID: <20190114223133.20e32e04@windsurf> (raw)
In-Reply-To: <20190112190743.7780-1-romain.naour@gmail.com>

Hello,

On Sat, 12 Jan 2019 20:07:43 +0100, Romain Naour wrote:
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
> 
> As reported by #11591, the xerver fail to load dri modules (r600_dri.so):
> 
> From Xorg.0.log:
> (EE) AIGLX error: dlopen of /full/path/to/sysroot/usr/lib/dri/r600_dri.so failed (/full/path/to/sysroot/usr/lib/dri/r600_dri.so: cannot open shared object file: No such file or directory)
> (II) GLX: no usable GL providers found for screen 0
> 
> That's because the xserver hardcode the dri divers directory path in
> DRI_DRIVER_PATH which come from
> dridriverdir=`$PKG_CONFIG --variable=dridriverdir dri`
> 
> We can see in dri.pc that dridriverdir use libdir which is now prefixed
> by the sysroot by pkgconf 1.5.3:
> 
> prefix=/usr
> exec_prefix=/usr
> libdir=${exec_prefix}/lib
> includedir=${prefix}/include
> dridriverdir=${libdir}/dri
> 
> Since we can't rely on pkgconf anymore, use --with-dri-driverdir="/usr/lib/dri"
> to use explicitly "/usr/lib/dri" instead of relying on dri.pc.
> 
> Tested using TestGlxinfo test from:
> http://patchwork.ozlabs.org/patch/1021669/
> 
> Fixes:
> https://bugs.buildroot.org/show_bug.cgi?id=11591
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>

I've applied after fixing the commit log, as I explained in my previous
reply.

> +	--with-dri-driverdir="/usr/lib/dri" \

I also dropped the double quotes around /usr/lib/dri.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2019-01-14 21:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 19:07 [Buildroot] [PATCH] package/mesa3d: override dri path Romain Naour
2019-01-13 13:11 ` Thomas Petazzoni
2019-01-14 21:31 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114223133.20e32e04@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox