From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/clapack+armadillo: re-enable on MIPS
Date: Thu, 31 Jan 2019 21:39:06 +0100 [thread overview]
Message-ID: <20190131203906.15410-1-patrickdepinguin@gmail.com> (raw)
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Commit d2b52cebf3b8b4a922a54d38a44a8a183406c5f1 disabled clapack on MIPS
platforms, to fix an autobuild failure (unfortunately, the results are no
longer available). The argument was:
"Disable this package for MIPS because it needs IRIX headers and
libraries."
Nevertheless, today compilation on MIPS seems to work fine. Testing was done
with test-pkg (armadillo depends on clapack):
$ echo "BR2_PACKAGE_ARMADILLO=y" > config.snippet;
$ utils/test-pkg -p armadillo -a -c config.snippet
br-mips32r6-el-hf-glibc [1/8]: OK
br-mips64-n64-full [2/8]: OK
br-mips64r6-el-hf-glibc [3/8]: OK
br-mipsel-o32-full [4/8]: OK
mips64el-ctng_n32-linux-gnu [5/8]: OK
mips64el-ctng_n64-linux-gnu [6/8]: OK
sourcery-mips64 [7/8]: OK
sourcery-mips [8/8]: OK
8 builds, 0 skipped, 0 build failed, 0 legal-info failed
Manual build tests were also done for mips32r2 with gcc 4.9.x and gcc 7.x,
and for M5150 with gcc 7.x (Buildroot-built toolchains in these three
cases).
Also building and running on Octeon III, using the toolchain provided by
Cavium Networks / Marvell, works fine.
Not seeing any problem (but also not understanding the original problem),
re-enable clapack (and armadillo) on MIPS. If any problems would pop up in
the future, they should be investigated in detail and a more fine-grained
solution should be taken than disabling on MIPS altogether.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
package/armadillo/Config.in | 2 --
package/clapack/Config.in | 1 -
2 files changed, 3 deletions(-)
diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
index 47c7cd9ffd..b2b61a3233 100644
--- a/package/armadillo/Config.in
+++ b/package/armadillo/Config.in
@@ -1,6 +1,5 @@
comment "armadillo needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP
- depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
depends on !BR2_powerpc
depends on !BR2_m68k_cf
@@ -11,7 +10,6 @@ comment "armadillo needs a glibc toolchain w/ C++"
config BR2_PACKAGE_ARMADILLO
bool "armadillo"
depends on BR2_INSTALL_LIBSTDCPP
- depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC # clapack
depends on !BR2_m68k_cf # clapack
select BR2_PACKAGE_CLAPACK
diff --git a/package/clapack/Config.in b/package/clapack/Config.in
index af7834d985..a912eb6c91 100644
--- a/package/clapack/Config.in
+++ b/package/clapack/Config.in
@@ -4,7 +4,6 @@ comment "clapack needs a glibc toolchain"
config BR2_PACKAGE_CLAPACK
bool "cblas/clapack"
- depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
# _fpu_control is used on PowerPC, but not available with
# uClibc or musl
depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
--
2.19.2
next reply other threads:[~2019-01-31 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 20:39 Thomas De Schampheleire [this message]
2019-02-04 13:34 ` [Buildroot] [PATCH] package/clapack+armadillo: re-enable on MIPS Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131203906.15410-1-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox