Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] aircrack-ng: add optional hwloc dependency
Date: Sat, 2 Feb 2019 15:03:20 +0100	[thread overview]
Message-ID: <20190202150320.3edb8af6@windsurf> (raw)
In-Reply-To: <20190130172835.4761-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Wed, 30 Jan 2019 18:28:33 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> hwloc dependency has been added in version 1.4 with
> https://github.com/aircrack-ng/aircrack-ng/commit/c31b27449962bc69638b32ec14e0ffdb8997dfcf
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/aircrack-ng/aircrack-ng.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Series applied, thanks. I hesitated a bit on PATCH 2/3, because we
typically don't really care about building tests in the context of
Buildroot. However, since unit tests in aircrack-ng are unconditionally
built, and the result depends on whether cmoka is available or not, it
makes sense to have it as an optional dependency.

Also, could you start using the convention of "package/<foo>" prefixes
for your commit titles ? We have finally standardized a bit the format
of commit titles, see:

  http://nightly.buildroot.org/manual.html#submitting-patches

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2019-02-02 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 17:28 [Buildroot] [PATCH 1/3] aircrack-ng: add optional hwloc dependency Fabrice Fontaine
2019-01-30 17:28 ` [Buildroot] [PATCH 2/3] aircrack-ng: add optional cmocka dependency Fabrice Fontaine
2019-01-30 17:28 ` [Buildroot] [PATCH 3/3] aircrack-ng: bump to version 1.5.2 Fabrice Fontaine
2019-02-02 14:03 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190202150320.3edb8af6@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox