From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/6] intel-gmmlib: new package.
Date: Sat, 2 Feb 2019 15:51:23 +0100 [thread overview]
Message-ID: <20190202155123.7200cc06@windsurf> (raw)
In-Reply-To: <20190131121526.11816-2-lpdev@cordier.org>
Hello,
Nit: there shouldn't be a final dot at end of commit title.
On Thu, 31 Jan 2019 13:15:21 +0100
Louis-Paul Cordier <lpdev@cordier.org> wrote:
> package/Config.in | 1 +
> package/intel-gmmlib/Config.in | 8 ++++++++
> package/intel-gmmlib/intel-gmmlib.hash | 2 ++
> package/intel-gmmlib/intel-gmmlib.mk | 17 +++++++++++++++++
Missing update to the DEVELOPERS file
> +sha256 e3114d7ddd429f1b9aa43a1b1d0086d881fbf4d90e4a90ab8577c369d2e3a5e1 intel-gmmlib-18.3.0.tar.gz
> diff --git a/package/intel-gmmlib/intel-gmmlib.mk b/package/intel-gmmlib/intel-gmmlib.mk
> new file mode 100644
> index 0000000000..e6ca3e5c5e
> --- /dev/null
> +++ b/package/intel-gmmlib/intel-gmmlib.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# intel-gmmlib
> +#
> +################################################################################
> +
> +INTEL_GMMLIB_VERSION = 18.3.0
There is an ewer 18.4.1 version available.
> +INTEL_GMMLIB_SITE = https://github.com/intel/gmmlib/archive
> +INTEL_GMMLIB_LICENSE = MIT
> +INTEL_GMMLIB_LICENSE_FILES = COPYING
> +
> +INTEL_GMMLIB_INSTALL_STAGING = YES
> +INTEL_GMMLIB_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +INTEL_GMMLIB_CONF_OPTS += -DRUN_TEST_SUITE=OFF
+= can be made just =.
Other than those minor nits, looks good to me.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-02 14:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 12:15 [Buildroot] [PATCH v2 0/6] *** Add Intel QuickSync support to ffmpeg *** Louis-Paul Cordier
2019-01-31 12:15 ` [Buildroot] [PATCH v2 1/6] intel-gmmlib: new package Louis-Paul Cordier
2019-02-02 14:51 ` Thomas Petazzoni [this message]
2019-02-04 9:32 ` Thomas Petazzoni
2019-01-31 12:15 ` [Buildroot] [PATCH v2 2/6] intel-mediadriver: " Louis-Paul Cordier
2019-02-02 16:03 ` Thomas Petazzoni
2019-02-04 9:23 ` lpdev at cordier.org
2019-01-31 12:15 ` [Buildroot] [PATCH v2 3/6] intel-mediasdk: " Louis-Paul Cordier
2019-02-04 9:41 ` Thomas Petazzoni
2019-01-31 12:15 ` [Buildroot] [PATCH v2 4/6] ffmpeg: bump to version 4.1. ffserver is not supported anymore Louis-Paul Cordier
2019-02-02 14:54 ` Thomas Petazzoni
2019-02-03 8:48 ` Bernd Kuhls
2019-02-03 14:40 ` Peter Korsgaard
2019-02-04 9:39 ` Thomas Petazzoni
2019-02-04 9:30 ` lpdev at cordier.org
2019-02-04 10:20 ` Thomas Petazzoni
2019-01-31 12:15 ` [Buildroot] [PATCH v2 5/6] ffmpeg: enable Intel QuickSync support Louis-Paul Cordier
2019-01-31 12:15 ` [Buildroot] [PATCH v2 6/6] Update DEVELOPERS Louis-Paul Cordier
2019-02-02 14:47 ` Thomas Petazzoni
2019-02-04 9:11 ` lpdev at cordier.org
2019-02-04 9:43 ` Thomas Petazzoni
2019-02-04 9:48 ` lpdev at cordier.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202155123.7200cc06@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox