Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v1] libv4l: fix qv4l2 libatomic related compile failure
Date: Mon, 4 Feb 2019 10:32:10 +0100	[thread overview]
Message-ID: <20190204093210.GA17819@scaer> (raw)
In-Reply-To: <20180212211922.12b3be43@windsurf.lan>

Peter, All,

On 2018-02-12 21:19 +0100, Thomas Petazzoni spake thusly:
> On Tue, 6 Feb 2018 22:02:59 +0100, Peter Seiderer wrote:
> > > On Sun,  4 Feb 2018 00:21:27 +0100, Peter Seiderer wrote:  
> > > > Fixes [1]:
> > > > 
> > > >   sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0'
> > > > 
> > > > [1] http://autobuild.buildroot.net/results/baa2595e1acdf4e795fbb940ca57fd136c827da3    
> > > 
> > > Did you analyze what part of the code is using atomic intrinsics? I
> > > don't see any use of atomic instrisics in qv4l2 itself (but perhaps I
> > > missed them), so they must be somewhere else.  
> > 
> > The atomic usage comes from the Qt5 libraries (libQt5Core.so,
> > libQt5Gui.so and libQt5Widgets.so)...
> 
> Isn't Qt installing some .pc files ? Are they being used by libv4l ? If
> so, are these .pc files referencing libatomic ?

So, this 1 year old patch is still pending, and you did not reply to
Thomas questiiiion about using the .pc files from Qt.

I've marked this patch as changes-requested in patchwork. If you believe
something is still needed, can you please respin an updated patch that
takes into account Thomas' comments.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2019-02-04  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03 23:21 [Buildroot] [RFC v1] libv4l: fix qv4l2 libatomic related compile failure Peter Seiderer
2018-02-04 22:43 ` Thomas Petazzoni
2018-02-06 21:02   ` Peter Seiderer
2018-02-12 20:19     ` Thomas Petazzoni
2019-02-04  9:32       ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204093210.GA17819@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox