From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/8] support/download/scp: fix download with scheme prefix 'scp://'
Date: Mon, 4 Feb 2019 19:05:46 +0100 [thread overview]
Message-ID: <20190204180553.18394-2-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <20190204180553.18394-1-patrickdepinguin@gmail.com>
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
The scp download helper is broken when the server URL starts with 'scp://'.
Such prefix is used in two situations:
1. to let FOO_SITE point to an scp location without explicitly having to set
'FOO_SITE_METHOD = scp'
2. when BR2_PRIMARY_SITE or BR2_BACKUP_SITE points to an scp location. In
this case, there is no equivalent of 'SITE_METHOD'.
Strip out the scheme prefix, similarly to how the 'file' download helper
does it. That helper has the same cases as above.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
support/download/scp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/support/download/scp b/support/download/scp
index 49cfff2b9f..80cf495c4e 100755
--- a/support/download/scp
+++ b/support/download/scp
@@ -34,4 +34,7 @@ _scp() {
eval ${SCP} "${@}"
}
+# Remove any scheme prefix
+uri="${uri##scp://}"
+
_scp ${verbose} "${@}" "'${uri}/${filename}'" "'${output}'"
--
2.19.2
next prev parent reply other threads:[~2019-02-04 18:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:05 [Buildroot] [PATCHv2 0/8] fix scp and reintroduce source-check target Thomas De Schampheleire
2019-02-04 18:05 ` Thomas De Schampheleire [this message]
2019-02-05 19:33 ` [Buildroot] [PATCHv2 1/8] support/download/scp: fix download with scheme prefix 'scp://' Peter Korsgaard
2019-02-18 22:20 ` Peter Korsgaard
2019-02-04 18:05 ` [Buildroot] [PATCHv2 2/8] support/download: reintroduce 'source-check' target Thomas De Schampheleire
2019-02-09 16:47 ` Arnout Vandecappelle
2019-02-09 20:08 ` Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 3/8] support/download/hg: implement source-check Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 4/8] support/download/wget: " Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 5/8] support/download/file: " Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 6/8] Config.in: reintroduce BR2_SSH Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 7/8] support/download/scp: implement source-check Thomas De Schampheleire
2019-02-09 16:48 ` Arnout Vandecappelle
2019-02-09 20:16 ` Thomas De Schampheleire
2019-02-04 18:05 ` [Buildroot] [PATCHv2 8/8] support/download/{bzr, cvs, git, svn}: highlight unimplemented source-check Thomas De Schampheleire
2019-02-04 18:24 ` [Buildroot] [PATCHv2 0/8] fix scp and reintroduce source-check target Thomas Petazzoni
2019-02-04 18:41 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204180553.18394-2-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox