Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add library xmlsec1
Date: Sun, 10 Feb 2019 15:20:19 +0100	[thread overview]
Message-ID: <20190210152019.353bc305@windsurf.home> (raw)
In-Reply-To: <CACHoAdp2+4-E8_KroYibuYxoFeT2groW-3-H+WS-M0aQDFvCDA@mail.gmail.com>

Hello Bastian,

On Sun, 10 Feb 2019 15:12:48 +0100
Bastian Breit <bastian.breit.buildroot@gmail.com> wrote:

> I locally fixed the formatting and licence part.

Great, thanks!

> I had some trouble with the mailing list and will use
> bastian.breit.buildroot at gmail.com from now on. 

Which trouble did you encounter ?

> We use libxmlsec1 in
> this context and haven't used another configuration. I am not sure,
> how the library works in other configuration. I would create config
> options for each option based on that list at
> https://www.aleksey.com/xmlsec/faq.html

No you don't have to support all options. If you don't support an
option (like gnutls or gcrypt), then do like you did: disable support
for it explicitly in the .mk file.

> Should I send changes for formatting & licences with a different patch
> or should I send an all in one patch?

Send all in one patch, labeled as "v2", with a changelog below the
"---" sign:

	git format-patch -v2 HEAD^

Edit the 0001-...patch file, and below the --- sign, add some notes
that explains what you changed since v1.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-02-10 14:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 21:53 [Buildroot] [PATCH] add library xmlsec1 Bastian Breit
2019-02-10  9:37 ` Thomas Petazzoni
2019-02-10 14:12   ` Bastian Breit
2019-02-10 14:20     ` Thomas Petazzoni [this message]
2019-02-10 14:40       ` Bastian Breit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190210152019.353bc305@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox