Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2019-02-11
Date: Tue, 12 Feb 2019 21:26:15 +0100	[thread overview]
Message-ID: <20190212212615.5beb3ec1@gmx.net> (raw)
In-Reply-To: <20190212070052.8321F87024@whitealder.osuosl.org>


On Tue, 12 Feb 2019 07:00:46 -0000, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

[...]
> Results for branch 'master'
> ===========================
> 
[...]
>          arm |                  libdrm-2.4.97 | NOK | http://autobuild.buildroot.net/results/68430721e9a22aab153f39800fd8db39b3a9941f |    

make[4]: Entering directory '/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-5/output/build/libdrm-2.4.97/tests/amdgpu'
  CC       amdgpu_test-basic_tests.o
  CC       amdgpu_test-amdgpu_test.o
  CC       amdgpu_test-bo_tests.o
basic_tests.c: In function 'amdgpu_userptr_test':
basic_tests.c:1649:7: warning: implicit declaration of function 'fork' [-Wimplicit-function-declaration]
  if (!fork()) {
       ^~~~
  CC       amdgpu_test-cs_tests.o
  CC       amdgpu_test-vce_tests.o
  CC       amdgpu_test-uvd_enc_tests.o
  CC       amdgpu_test-vcn_tests.o
  CC       amdgpu_test-deadlock_tests.o
  CC       amdgpu_test-vm_tests.o
  CCLD     amdgpu_test
amdgpu_test-basic_tests.o: In function `amdgpu_userptr_test':
basic_tests.c:(.text+0xbd4): undefined reference to `fork'
collect2: error: ld returned 1 exit status
Makefile:458: recipe for target 'amdgpu_test' failed


From libdrm-2.4.97/tests/Makefile.am:

	if HAVE_AMDGPU
	if HAVE_CUNIT
	SUBDIRS += amdgpu
	endif
	endif

This is the only place where HAVE_CUNIT is evaluated (and the '--enable-install-test-programs'
option only triggers the install vs. not-install and not the building of the tests),
so package/libdrm/libdrm.mk could/should be changed to:

--- a/package/libdrm/libdrm.mk
+++ b/package/libdrm/libdrm.mk
@@ -47,6 +47,9 @@ endif
 --- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -38,6 +38,7 @@ config BR2_PACKAGE_LIBDRM_AMDGPU
        bool "amdgpu"
        depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
        select BR2_PACKAGE_LIBDRM_ENABLE_ATOMIC
+       depends on BR2_USE_MMU && !BR2_PACKAGE_CUNIT # fork
        help
          Install AMD GPU driver.

 ifeq ($(BR2_PACKAGE_LIBDRM_AMDGPU),y)
 LIBDRM_CONF_OPTS += --enable-amdgpu
+ifeq ($(BR2_PACKAGE_CUNIT),y)
+LIBDRM_DEPENDENCIES += cunit
+endif
 else
 LIBDRM_CONF_OPTS += --disable-amdgpu
 endif
@@ -115,9 +118,6 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBDRM_INSTALL_TESTS),y)
 LIBDRM_CONF_OPTS += --enable-install-test-programs
-ifeq ($(BR2_PACKAGE_CUNIT),y)
-LIBDRM_DEPENDENCIES += cunit
-endif
 endif

and package/libdrm/Config.in to:

--- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -38,6 +38,7 @@ config BR2_PACKAGE_LIBDRM_AMDGPU
        bool "amdgpu"
        depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
        select BR2_PACKAGE_LIBDRM_ENABLE_ATOMIC
+       depends on BR2_USE_MMU && !BR2_PACKAGE_CUNIT # fork
        help
          Install AMD GPU driver.

But this seems strange, maybe better solution would be an additional '--disable-build-test-programs'
option?

Regards,
Peter

      reply	other threads:[~2019-02-12 20:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12  7:00 [Buildroot] [autobuild.buildroot.net] Build results for 2019-02-11 Thomas Petazzoni
2019-02-12 20:26 ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212212615.5beb3ec1@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox