[Buildroot] [PATCH 2/2] package/snort: build with OpenAppID support if luajit/openssl is enabled

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Sergio,

Thanks for the patch.

On Thu, 21 Feb 2019 17:27:26 -0300
Sergio Prado <sergio.prado@e-labworks.com> wrote:

> Since version 2.9.12, OpenAppID [1] is enabled by default.
> 
> OpenAppID depends on luajit and openssl. If we leave it enabled by
> default, snort would require luajit. Since luajit is not available on
> all architectures, that would limit the usage of the snort package.
> 
> Since not all users will need/use OpenAppID, let's leave it disabled by
> default. To build with OpenAppID support, the user will need to enable
> luajit and libssl.
> 
> Also, it is necessary to apply a patch to fix a compile error when
> building OpenAppID with uclibc and musl. The build fails when
> dereferencing the rpcent structure because rpc.h is not been included.
> 
> [1] https://www.snort.org/downloads/openappid/9553
> 
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>

Shouldn't this be squashed into PATCH 1/2 ? Indeed, if I applied just
PATCH 1/2, then I suppose snort will no longer build on architectures
that don't support Luajit.

Alternatively PATCH 1/2 could have an unconditional
--disable-open-appid, and then PATCH 2/2 adds the logic to enable
OpenAppID support when possible.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com