From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/1] package/libwebsockets: bump version to 3.1.0
Date: Mon, 25 Feb 2019 22:20:58 +0100 [thread overview]
Message-ID: <20190225222058.1d0a106b@windsurf.home> (raw)
In-Reply-To: <20190223201736.106101-1-aduskett@gmail.com>
Hello Adam,
On Sat, 23 Feb 2019 15:17:36 -0500
aduskett at gmail.com wrote:
> +-if (LWS_WITH_LIBEV AND LWS_WITH_LIBEVENT)
> +- message(FATAL_ERROR "Sorry libev and libevent conflict with each others' namespace, you can only have one or the other")
> +-endif()
I'm a bit confused by this patch. Why are removing this check ? If
libwebsockets is anyway only using libev *or* libevent, what about
changing libwebsockets.mk to only allow using one or the other ?
This is the only point I've seen, the rest looks good to me.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-25 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 20:17 [Buildroot] [PATCH next 1/1] package/libwebsockets: bump version to 3.1.0 aduskett at gmail.com
2019-02-25 21:20 ` Thomas Petazzoni [this message]
2019-02-27 17:19 ` Adam Duskett
2019-04-03 21:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225222058.1d0a106b@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox