From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/qt5/qt5base: add custom configure options last
Date: Fri, 1 Mar 2019 08:28:15 +0100 [thread overview]
Message-ID: <20190301082815.21ede3d8@windsurf.home> (raw)
In-Reply-To: <20190301021712.47698-1-james.grant@jci.com>
Hello James,
On Fri, 1 Mar 2019 15:17:11 +1300
James Grant <james.grant@jci.com> wrote:
> This allows all options set by Buildroot to be overridden.
>
> Signed-off-by: James Grant <james.grant@jci.com>
> ---
> package/qt5/qt5base/qt5base.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 11c6684812..8c0f5f0c9f 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -296,6 +296,9 @@ define QT5BASE_CONFIGURE_HOSTCC
> $(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX = $(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
> endef
>
> +# Must be last so can override all options set by Buildroot
> +QT5BASE_CONFIGURE_OPTS += $(call qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS))
Shouldn't this line also be removed from where it originally was ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-01 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 2:17 [Buildroot] [PATCH 1/2] package/qt5/qt5base: add custom configure options last James Grant
2019-03-01 2:17 ` [Buildroot] [PATCH 2/2] package/qt5/qt5base: exclude OpenSSL functionality for Qt 5.6.x James Grant
2019-03-01 9:14 ` Peter Korsgaard
2019-03-01 7:28 ` Thomas Petazzoni [this message]
2019-03-01 7:36 ` [Buildroot] [PATCH 1/2] package/qt5/qt5base: add custom configure options last James Grant
2019-03-01 9:13 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301082815.21ede3d8@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox