From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/optee-*: packages depend on thread support
Date: Thu, 7 Mar 2019 22:31:42 +0100 [thread overview]
Message-ID: <20190307223142.2fb09608@windsurf> (raw)
In-Reply-To: <1551973528-5130-1-git-send-email-etienne.carriere@linaro.org>
Hello Etienne,
On Thu, 7 Mar 2019 16:45:28 +0100
Etienne Carriere <etienne.carriere@linaro.org> wrote:
> BR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS.
> Library teec uses pthread support to protect clients state
> management.
>
> This change declares this dependency in package optee-client and
> updates dependent packages accordingly: optee-benchmark,
> optee-client, optee-examples and optee-test.
>
> Fixes [1] and [2] where config selected an toolchain without thread
> support and build failed with trace like:
>
> CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
> Could NOT find Threads (missing: Threads_FOUND)
> Call Stack (most recent call first):
> /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
> /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
> libteec/CMakeLists.txt:8 (find_package)
>
> [1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e
> [2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1
>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> Changes v2 -> v3:
> - Squash v2 series into a single patch.
> - Update config comment for unmet dependencies.
Applied to master after fixing the dependencies of the Config.in
comment entries, as noticed by Baruch (thanks for the review!).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-03-07 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:29 [Buildroot] [PATCH] package/optee-client: depends on thread support Etienne Carriere
2019-03-07 9:35 ` Baruch Siach
2019-03-07 10:02 ` Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 1/4] " Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 2/4] package/optee-benchmark: thread dependency from optee-client Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 3/4] package/optee-examples: " Etienne Carriere
2019-03-07 14:48 ` [Buildroot] [PATCH v2 4/4] package/optee-test: " Etienne Carriere
2019-03-07 15:10 ` [Buildroot] [PATCH v2 1/4] package/optee-client: depends on thread support Baruch Siach
2019-03-07 15:30 ` Etienne Carriere
2019-03-07 15:45 ` [Buildroot] [PATCH v3] package/optee-*: packages depend " Etienne Carriere
2019-03-07 17:13 ` Baruch Siach
2019-03-07 17:22 ` Etienne Carriere
2019-03-07 21:31 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307223142.2fb09608@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox