From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2
Date: Sat, 9 Mar 2019 15:00:11 +0100 [thread overview]
Message-ID: <20190309150011.3968dca9@windsurf> (raw)
In-Reply-To: <20190308194411.8573-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
+Arnout in Cc.
On Fri, 8 Mar 2019 20:44:11 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> mongodb (like gnuradio) needs host-python2 however there is no way to
> enforce this so add a dependency on !BR2_PACKAGE_PYTHON3.
> Indeed, if BR2_PACKAGE_PYTHON3 is selected, then buildroot will only
> build and install host-python-typing for host-python3.
>
> This issue was not raised in the previous version of mongodb as
> host-scons was the only dependency however we now have
> host-python-typing and host-python-pyyaml dependencies and it
> does not seem right to enforce python2 on those packages
>
> Fixes:
> - http://autobuild.buildroot.org/results/693bdba2c01a1b69f56d6ee75094a6a0fc3f40b4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
You forgot to propagate the !BR2_PACKAGE_PYTHON3 dependency to the
Config.in comment of mongodb, so I did that and applied.
However, in fact I'm not sure to agree with your statement that it does
not seem right to enforce python2 on host-python-typing and
host-python-pyyaml. The only package using them *is* mongodb. So
perhaps for those packages we could have the same principle as
python-setuptools, where python-setuptools is a target package for
python2/python3 but only a host package for python2, and there is a
separate python3-setuptools package to install host setuptools for
python3. It's not great, but it works. I don't know if it's worth it
doing that for mongodb though.
Thoughts ?
Life will be easier when there'll be only one Python version to
support...
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-09 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 19:44 [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2 Fabrice Fontaine
2019-03-09 14:00 ` Thomas Petazzoni [this message]
2019-03-25 16:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309150011.3968dca9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox