From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libdrm: fix build without fork
Date: Mon, 11 Mar 2019 22:54:21 +0100 [thread overview]
Message-ID: <20190311225421.31ebff20@windsurf> (raw)
In-Reply-To: <CAPi7W82UfzUoZ_SuNoA4BQc8RfosQW_RCu9F+105p-6yD=3rQw@mail.gmail.com>
Hello,
On Mon, 11 Mar 2019 18:52:37 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Will the test succeed without fork? Maybe better disable the whole test in case
> > fork is not available? Or simple wait for Upstream suggestions/opinion.... ;-)
> Indeed, you were right, the test won't succeed but upstream does not
> want to disable the test either:
> https://patchwork.freedesktop.org/patch/291508.
> Should we add a dependency on BR2_USE_MMU to libdrm and all its
> reverse dependencies?
Why on libdrm ?
As upstream said: amdgpu is never going to be used on noMMU platforms,
and the amdgpu tests are only compiled in when the amdgpu driver is
enabled. From tests/Makefile.am:
if HAVE_AMDGPU
if HAVE_CUNIT
SUBDIRS += amdgpu
endif
endif
So, just make BR2_PACKAGE_LIBDRM_AMDGPU depends on BR2_USE_MMU. Isn't
that sufficient ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-11 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 9:46 [Buildroot] [PATCH 1/1] package/libdrm: fix build without fork Fabrice Fontaine
2019-03-10 18:17 ` Peter Seiderer
2019-03-11 17:52 ` Fabrice Fontaine
2019-03-11 21:54 ` Thomas Petazzoni [this message]
2019-03-11 22:11 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311225421.31ebff20@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox