From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 02/13] qt5: Convert to generic target install command
Date: Thu, 14 Mar 2019 12:06:10 +0100 [thread overview]
Message-ID: <20190314120610.4ee82dd9@windsurf> (raw)
In-Reply-To: <580bc2fc-615a-f200-0428-1096d2dcdf63@mind.be>
On Thu, 14 Mar 2019 12:01:16 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:
> > One issue with this approach is that if you do a complete build, and
> > then do "make qt5base-reinstall", then the date of the .stamp_built
> > file of qt5base has not changed, and will be older than the one of all
> > other packages that have been built after qt5base. Therefore, the rsync
> > that you do will copy again not only the files from qt5base, but also
> > the ones from all other packages that have been built after qt5base.
>
> I agree that this is a problem.
>
> But I think it can be easily solved by using the pkg-file-list instead of find.
> Since we already have a dependency of target on staging, we know that the
> pkg-file-list is up-to-date.
True.
> > I continue to believe we want to find a solution where "make
> > INSTALL_ROOT=$(TARGET_DIR) install" and "make
> > INSTALL_ROOT=$(STAGING_DIR) install" works properly.
>
> I disagree. I think the pattern of installing to staging and then copying to
> target is a good pattern.
We basically don't use this pattern anywhere. I would agree with the
general direction of killing the staging vs. target difference, and
simply produce "target" out of "staging" at the very end of the build,
but that's a huge undertaking.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-14 11:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 9:40 [Buildroot] [PATCH v2 00/13] ppsh compatible Qt5 / generic qmake target install Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 01/13] qt5base: Do not build shared libs if BR2_STATIC_LIBS is chosen Andreas Naumann
2019-03-14 10:07 ` Thomas Petazzoni
2019-03-14 9:40 ` [Buildroot] [PATCH v2 02/13] qt5: Convert to generic target install command Andreas Naumann
2019-03-14 10:13 ` Thomas Petazzoni
2019-03-14 11:01 ` Arnout Vandecappelle
2019-03-14 11:06 ` Thomas Petazzoni [this message]
2019-03-14 11:20 ` Arnout Vandecappelle
2019-03-14 13:30 ` Thomas Petazzoni
2019-03-14 13:35 ` Andreas Naumann
2019-03-14 13:49 ` Thomas Petazzoni
2019-03-14 9:40 ` [Buildroot] [PATCH v2 03/13] qt5base: Fix inconsistencies when overriding qmake properties Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 04/13] qt5: Remove *.la/*.prl fixup script Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 05/13] qt5: Use qmake via QT5_QMAKE variable Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 06/13] core: implement per-package SDK and target Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 07/13] Makefile: allow top-level parallel build with BR2_PER_PACKAGE_DIRECTORIES=y Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 08/13] package/pkg-generic: make libtool .la files compatible with per-package directories Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 09/13] package/pkg-kconfig: handle KCONFIG_DEPENDENCIES " Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 10/13] docs/manual: add details about top-level parallel build support Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 11/13] docs/manual: document the effect of per-package directory on variables Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 12/13] qt5: Prepare qmake for per-package infrastructure Andreas Naumann
2019-03-14 9:40 ` [Buildroot] [PATCH v2 13/13] qt5: Fix pkgconfig search path " Andreas Naumann
2019-03-14 11:03 ` [Buildroot] [PATCH v2 00/13] ppsh compatible Qt5 / generic qmake target install Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314120610.4ee82dd9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox