From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 14 Mar 2019 21:16:15 +0100 Subject: [Buildroot] [PATCH 1/2] package/ulogd: add postgresql optional dependency In-Reply-To: <20190313181512.2668-1-fontaine.fabrice@gmail.com> References: <20190313181512.2668-1-fontaine.fabrice@gmail.com> Message-ID: <20190314211615.0cbad150@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Wed, 13 Mar 2019 19:15:11 +0100 Fabrice Fontaine wrote: > Signed-off-by: Fabrice Fontaine > --- > package/ulogd/ulogd.mk | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) I've applied, but I have a few comments, see below. > > diff --git a/package/ulogd/ulogd.mk b/package/ulogd/ulogd.mk > index 5b0e558930..5ea127f630 100644 > --- a/package/ulogd/ulogd.mk > +++ b/package/ulogd/ulogd.mk > @@ -7,7 +7,7 @@ > ULOGD_VERSION = 2.0.5 > ULOGD_SOURCE = ulogd-$(ULOGD_VERSION).tar.bz2 > ULOGD_SITE = http://www.netfilter.org/projects/ulogd/files > -ULOGD_CONF_OPTS = --with-dbi=no --with-pgsql=no > +ULOGD_CONF_OPTS = --with-dbi=no Would be nice to use --without-foo instead of --with-foo=. > ULOGD_DEPENDENCIES = host-pkgconf \ > libmnl libnetfilter_acct libnetfilter_conntrack libnetfilter_log \ > libnfnetlink > @@ -22,11 +22,17 @@ ULOGD_DEPENDENCIES += mysql > else > ULOGD_CONF_OPTS += --with-mysql=no Ditto --without. > endif > +ifeq ($(BR2_PACKAGE_POSTGRESQL),y) > +ULOGD_CONF_OPTS += --with-pgsql > +ULOGD_DEPENDENCIES += postgresql > +else > +ULOGD_CONF_OPTS += --without-pgsql > +endif > ifeq ($(BR2_PACKAGE_SQLITE),y) > ULOGD_DEPENDENCIES += sqlite Any idea why we don't do --with-sqlite / --without-sqlite ? > endif > else > -ULOGD_CONF_OPTS += --with-mysql=no --without-sqlite > +ULOGD_CONF_OPTS += --with-mysql=no --without-pgsql --without-sqlite Ditto --without. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com