From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/uboot-tools: Fix loop positional declaration build error
Date: Mon, 18 Mar 2019 17:12:37 +0100 [thread overview]
Message-ID: <20190318171237.032f635c@windsurf> (raw)
In-Reply-To: <1552923418-22447-1-git-send-email-email@gmail.com>
On Mon, 18 Mar 2019 17:36:58 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> From: Vadim Kochan <vadim4j@gmail.com>
>
> Move 'i' variable outside of the 'for' loop to separate declaration
> in lib/crc16.c
>
> Fixes:
> http://autobuild.buildroot.net/results/332c9d2232c03440bf71794ee7850b1f6fd51d11/
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Thanks for the fix, but I already submitted a similar one, and upstream
U-Boot wants to handle this different, see
https://lists.denx.de/pipermail/u-boot/2019-February/358821.html. I
didn't get to doing the change upstream U-Boot suggested.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-18 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 15:36 [Buildroot] [PATCH 1/1] package/uboot-tools: Fix loop positional declaration build error Vadim Kochan
2019-03-18 16:12 ` Thomas Petazzoni [this message]
2019-03-18 16:22 ` Vadym Kochan
2019-03-25 10:59 ` Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318171237.032f635c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox