From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 2/4] boot/opensbi: new package
Date: Wed, 20 Mar 2019 22:12:36 +0100 [thread overview]
Message-ID: <20190320221236.1ea9c11b@windsurf> (raw)
In-Reply-To: <20190320003706.1126-2-alistair.francis@wdc.com>
Hello Francis,
You are respining the patches too fast, without answering some of the
questions, and therefore there's still an issue, see below.
On Wed, 20 Mar 2019 00:38:05 +0000
Alistair Francis <Alistair.Francis@wdc.com> wrote:
> +ifneq ($(OPENSBI_PLAT),)
> +OPENSBI_PLAT_INSTALL = \
> + $(INSTALL) -m 0644 -D $(@D)/build/platform/$(OPENSBI_PLAT)/firmware/fw_jump.bin $(BINARIES_DIR)/fw_jump.bin; \
> + $(INSTALL) -m 0644 -D $(@D)/build/platform/$(OPENSBI_PLAT)/firmware/fw_jump.elf $(BINARIES_DIR)/fw_jump.elf
> +endif
> +
> +# Install libsbi.a in the host lib dir so it can be linked in the future.
> +define OPENSBI_INSTALL_IMAGES_CMDS
> + $(OPENSBI_PLAT_INSTALL)
> + $(INSTALL) -m 0644 -D $(@D)/build/lib/libsbi.a $(HOST_DIR)/usr/lib
I suppose that libsbi.a contains code cross-compiled for RISC-V, so
installing it in $(HOST_DIR) is wrong in this case. It should go in
$(STAGING_DIR).
The second question, which I asked in my review of your v4 is whether
this library is meant to be linked into bare-metal code (which is what
I would expect for something related to firmware) or to Linux
user-space applications. In the latter case, installing to
$(STAGING_DIR)/usr/lib is the right thing to do. In the former case
however, it should probably be installed elsewhere, maybe
$(STAGING_DIR)/usr/share/opensbi (but I'm not a FHS expert).
Also, when -D is used, the destination path should include the filename.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-20 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 0:38 [Buildroot] [PATCH v5 1/4] board/qemu/riscv32-virt: Update linux config Alistair Francis
2019-03-20 0:38 ` [Buildroot] [PATCH v5 2/4] boot/opensbi: new package Alistair Francis
2019-03-20 21:12 ` Thomas Petazzoni [this message]
2019-03-20 21:28 ` Alistair Francis
2019-03-20 21:44 ` Thomas Petazzoni
2019-03-21 16:36 ` Mark Corbin
2019-03-21 16:57 ` Thomas Petazzoni
2019-03-23 6:44 ` Alistair Francis
2019-03-20 0:38 ` [Buildroot] [PATCH v5 3/4] configs: qemu_riscv*_virt: Use OpenSBI by default Alistair Francis
2019-03-20 0:38 ` [Buildroot] [PATCH v5 4/4] boot/riscv-pk: Deprecate riscv-pk and BBL Alistair Francis
2019-03-20 19:20 ` [Buildroot] [PATCH v5 1/4] board/qemu/riscv32-virt: Update linux config Arnout Vandecappelle
2019-03-20 22:50 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320221236.1ea9c11b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox