From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/qt5base: fix xkbcommon option
Date: Thu, 21 Mar 2019 22:33:13 +0100 [thread overview]
Message-ID: <20190321213313.GC2660@scaer> (raw)
In-Reply-To: <20190321212323.22920-1-ps.report@gmx.net>
Peter, All,
On 2019-03-21 22:23 +0100, Peter Seiderer spake thusly:
> - Qt 5.6: according to configure --help the command line option to
> enable x11 xkbcommon support is '-system-xkbcommon-x11'
>
> - Qt 5.12: according to configure --help the command line option to
> enable xkbcommon support is '-xkbcommon'
>
> Fixes [1]:
>
> ERROR: Invalid value given for boolean command line option 'xkbcommon'.
>
> [1] http://autobuild.buildroot.net/results/87076d03bb92a9940447ca80fc1f202e35ef39da
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/qt5/qt5base/qt5base.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 14536980a8..b0469172c0 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -153,7 +153,13 @@ QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_DIRECTFB),-directfb,-no-dir
> QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_DIRECTFB),directfb)
>
> ifeq ($(BR2_PACKAGE_QT5BASE_XCB),y)
> -QT5BASE_CONFIGURE_OPTS += -xcb -system-xkbcommon
> +QT5BASE_CONFIGURE_OPTS += -xcb
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_5_6),y)
> +QT5BASE_CONFIGURE_OPTS += -xcb -system-xkbcommon-x11
> +else
> +QT5BASE_CONFIGURE_OPTS += -xcb -xkbcommon
Two things:
1. -xcb is passed twice: once uncoditionally on the Qt version, and
once for each Qt version;
2. The build failure you reference is about a qt-5.12 build, which
complains about an "Invalid value given for boolean command line
option 'xkbcommon'".
So, it looks like qt-5.12 does not linke -xkbcommon, but this is exactly
what you are passing with this patch...
Did I misunderstand something?
Cordialement,
Yann E. MORIN.
> +endif
> +
> QT5BASE_DEPENDENCIES += \
> libxcb \
> xcb-util-wm \
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-03-21 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 21:23 [Buildroot] [PATCH v1] package/qt5base: fix xkbcommon option Peter Seiderer
2019-03-21 21:33 ` Yann E. MORIN [this message]
2019-03-21 21:56 ` Peter Seiderer
2019-03-21 22:28 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321213313.GC2660@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox