Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/openjdk: Add architecture support list
Date: Mon, 25 Mar 2019 17:54:38 +0100	[thread overview]
Message-ID: <20190325175438.73aee6c9@windsurf> (raw)
In-Reply-To: <20190325153733.14885-1-aduskett@gmail.com>

Hello Adam,

On Mon, 25 Mar 2019 11:37:33 -0400
aduskett at gmail.com wrote:

> +# Taken from make/autoconf/platform.m4
> +config BR2_PACKAGE_OPENJDK_BIN_ARCH_SUPPORTS

This should have been just:

	BR2_PACKAGE_OPENJDK_ARCH_SUPPORTS

>  comment "openjdk needs X.Org"
> +	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS

Valgrind ?

Should have been:

+	depends on BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_OPENJDK_ARCH_SUPPORTS


>  comment "openjdk needs glibc, and a toolchain w/ wchar, dynamic library, threads, C++"
>  	depends on BR2_USE_MMU
> +	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS

Ditto.

>  comment "openjdk does not support soft float configurations"
> +	depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS

Ditto.

I fixed those issues and applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-03-25 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 15:37 [Buildroot] [PATCH 1/1] package/openjdk: Add architecture support list aduskett at gmail.com
2019-03-25 16:54 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325175438.73aee6c9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox