From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 25 Mar 2019 18:01:08 +0100 Subject: [Buildroot] [PATCH v2] board: rename pine64 to pine64_a64 In-Reply-To: References: <20190202040519.14568-1-philip.a.molloy@gmail.com> Message-ID: <20190325180108.15704071@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, I haven't seen the original patch. Was it sent to the Buildroot mailing list ? It doesn't seem like it reached the mailing list. Philip: did you register on the mailing list before sending your patch ? If not, could you subscribe to the mailing list and resend ? Thanks! On Mon, 25 Mar 2019 10:43:45 +0530 Jagan Teki wrote: > > N: James Hilliard > > diff --git a/board/pine64/pine64/boot.cmd b/board/pine64/a64/boot.cmd > > similarity index 100% > > rename from board/pine64/pine64/boot.cmd > > rename to board/pine64/a64/boot.cmd > > diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/a64/genimage.cfg > > similarity index 100% > > rename from board/pine64/pine64/genimage.cfg > > rename to board/pine64/a64/genimage.cfg > > pine64 is vendor who produced pine64 board. and same vendor producing > sopine. so renaming to a64 doesn't valid. What? I'm sorry I don't understand what you mean here. The typical Buildroot folder organization is: board/// pine64 is indeed a vendor name, and a64 is a board name, according to https://www.pine64.org/?page_id=46823. So the change looks perfect correct to me. It will allow to add support for other boards produced by Pine64, in board/pine64//. > > -Pine64 link: > > +Pine A64 link: > > https://www.pine64.org/?page_id=1194 > > It has wiki link below, that intern routing pine64 board link. wiki > has Mainline stuff information. I'm not a native English speaker, so I might be wrong, but I believe "that intern routing pine64 board link" doesn't make any sense in English. What are you trying to say here ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com