Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3 v3] support/graph-depends: don't eliminate mandatory deps for reverse graphs
Date: Mon, 25 Mar 2019 19:36:03 +0100	[thread overview]
Message-ID: <20190325193603.29f39824@windsurf> (raw)
In-Reply-To: <e80973941296758686f7129ecf12d6bee9037c4e.1553288807.git.yann.morin.1998@free.fr>

On Fri, 22 Mar 2019 22:07:06 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> We we simplify the dependency graph, we try to remove so-called
> mandatory dependencies from each package, and for each mandatory that
> was thus removed, reattach it to the root-package of the graph.
> 
> This was made so that mandatory dependencies (which are dependencies of
> all packages, or at least of a lot of packages) do not clutter the
> dependency graph, but that they are still shown in the graph, as
> dependencies of the root package.
> 
> However, these mandatory dependencies are only _direct_ dependencies.
> As such, it does not make sense to reattach a mandatory dependency when
> doing a reverse graph. Worse, it can actually be incorrect.
> 
> For example, 'skeleton' is a mandatory dependency, and as such is
> removed from all packages. But when doing a reverse graph, skeleton is
> now in the dependency chain of, e.g. skeleton-init-none; it should then
> not be removed.
> 
> In short: the notion of mandatory dependencies does not make sense in
> the case of a reverse graph.
> 
> Consequently, skip over the mandatory dependency removal when doing a
> reverse graph.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  support/scripts/graph-depends | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-03-25 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 21:07 [Buildroot] [PATCH 0/3 v3] support/graphs: speedup graph-depends (branch yem/graphs-from-make-2) Yann E. MORIN
2019-03-22 21:07 ` [Buildroot] [PATCH 1/3 v3] package/pkg-generic: mark some rule PHONY Yann E. MORIN
2019-03-25 18:27   ` Thomas Petazzoni
2019-03-22 21:07 ` [Buildroot] [PATCH 2/3 v3] support/graph-depends: don't eliminate mandatory deps for reverse graphs Yann E. MORIN
2019-03-25 18:36   ` Thomas Petazzoni [this message]
2019-03-22 21:07 ` [Buildroot] [PATCH 3/3 v3] support/graph-depends: use the new make-based dependency tree Yann E. MORIN
2019-03-25 18:36   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325193603.29f39824@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox