From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 3/5] boot/opensbi: new package
Date: Tue, 26 Mar 2019 14:57:08 +0100 [thread overview]
Message-ID: <20190326145708.6f8946e4@windsurf> (raw)
In-Reply-To: <20190320230422.13592-3-alistair.francis@wdc.com>
Hello,
On Wed, 20 Mar 2019 23:05:21 +0000
Alistair Francis <Alistair.Francis@wdc.com> wrote:
> OpenSBI is a much improved alternative to BBL (riscv-pk). Add OpenSBI
> support to buildroot.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
I have applied, but after doing a few changes for things that were not
completely correct. See below.
> +OPENSBI_VERSION = v0.3
> +OPENSBI_SITE = $(call github,riscv,opensbi,$(OPENSBI_VERSION))
> +OPENSBI_LICENSE = BSD-2-Clause
> +OPENSBI_LICENSE_FILES = COPYING.BSD
> +OPENSBI_INSTALL_IMAGES = YES
This is only really needed when OPENSBI_PLAT != "", so I've moved this
statement inside the appropriate condition.
I've added OPENSBI_INSTALL_TARGET = NO, because we're not installing
anything to target.
But more importantly, I've added OPENSBI_INSTALL_STAGING = YES, without
which your OPENSBI_INSTALL_STAGING_CMDS is never called. I'm not sure
how you tested this, but it clearly couldn't work as is.
> +# Install libsbi.a in the host lib dir so it can be linked in the future.
The library is not installed in host dir. So I've changed this to
rather explain why we install in usr/share/opensbi and not in usr/lib.
Applied with those issues fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-26 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 23:05 [Buildroot] [PATCH v6 1/5] board/qemu/riscv32-virt: Convert defconfig into a fragment Alistair Francis
2019-03-20 23:05 ` [Buildroot] [PATCH v6 3/5] boot/opensbi: new package Alistair Francis
2019-03-26 13:57 ` Thomas Petazzoni [this message]
2019-03-26 22:21 ` Alistair Francis
2019-03-20 23:05 ` [Buildroot] [PATCH v6 2/5] board/qemu/riscv32-virt: Simplify the linux config Alistair Francis
2019-03-26 12:31 ` Thomas Petazzoni
2019-03-20 23:05 ` [Buildroot] [PATCH v6 4/5] configs: qemu_riscv*_virt: Use OpenSBI by default Alistair Francis
2019-03-26 14:01 ` Thomas Petazzoni
2019-03-20 23:05 ` [Buildroot] [PATCH v6 5/5] boot/riscv-pk: Deprecate riscv-pk and BBL Alistair Francis
2019-03-26 14:01 ` Thomas Petazzoni
2019-03-26 12:31 ` [Buildroot] [PATCH v6 1/5] board/qemu/riscv32-virt: Convert defconfig into a fragment Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326145708.6f8946e4@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox