From: Ed Blake <ed.blake@sondrel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 0/4] toolchain-external: add OpenMP support
Date: Wed, 27 Mar 2019 18:51:40 +0000 [thread overview]
Message-ID: <20190327185129.10dee1f5@blake-linux> (raw)
In-Reply-To: <20190326202222.0dbc0711@windsurf>
On Tue, 26 Mar 2019 20:22:22 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Ed,
>
> On Tue, 26 Mar 2019 12:30:44 +0000
> Ed Blake <ed.blake@sondrel.com> wrote:
>
> > Ed Blake (4):
> > toolchain-external: introduce BR2_TOOLCHAIN_HAS_OPENMP
> > package/gcc: select BR2_TOOLCHAIN_HAS_OPENMP if BR2_GCC_ENABLE_OPENMP
> > toolchain-external: enable OpenMP for supporting toolchains
> > package: use BR2_TOOLCHAIN_HAS_OPENMP
>
> Thanks, I've applied all four patches.
>
> However, it would be good if you could send additional patches that:
>
> (1) Allows a custom external toolchain to specify that it supports
> OpenMP. This needs to be done in
> toolchain/toolchain-external/toolchain-external-custom/Config.in.options
>
> (2) Adds a check to the external toolchain logic to ensure that if
> BR2_TOOLCHAIN_HAS_OPENMP is enabled, the toolchain really supports
> it. This should be done in the $(2)_CONFIGURE_CMDS variable in
> pkg-toolchain-external.mk. You can for example write a check
> similar to check_fortran (see helpers.mk) that tries to compile a
> simple OpenMP program.
>
> Do you think you could work on this ?
Sure, will do.
Ed.
>
> Thanks!
>
> Thomas
prev parent reply other threads:[~2019-03-27 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 12:30 [Buildroot] [PATCH v2 0/4] toolchain-external: add OpenMP support Ed Blake
2019-03-26 12:30 ` [Buildroot] [PATCH v2 2/4] package/gcc: select BR2_TOOLCHAIN_HAS_OPENMP if BR2_GCC_ENABLE_OPENMP Ed Blake
2019-03-26 12:30 ` [Buildroot] [PATCH v2 1/4] toolchain-external: introduce BR2_TOOLCHAIN_HAS_OPENMP Ed Blake
2019-03-26 12:30 ` [Buildroot] [PATCH v2 3/4] toolchain-external: enable OpenMP for supporting toolchains Ed Blake
2019-03-26 12:30 ` [Buildroot] [PATCH v2 4/4] package: use BR2_TOOLCHAIN_HAS_OPENMP Ed Blake
2019-03-26 13:53 ` [Buildroot] [PATCH v2 0/4] toolchain-external: add OpenMP support Thomas Petazzoni
2019-03-26 14:06 ` Ed Blake
2019-03-26 19:22 ` Thomas Petazzoni
2019-03-27 18:51 ` Ed Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327185129.10dee1f5@blake-linux \
--to=ed.blake@sondrel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox