From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 28 Mar 2019 17:22:29 +0100 Subject: [Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test In-Reply-To: <20190219154311.22173-1-francois.perrad@gadz.org> References: <20190219154311.22173-1-francois.perrad@gadz.org> Message-ID: <20190328172229.51ddf155@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Fran?ois, On Tue, 19 Feb 2019 16:43:01 +0100 Francois Perrad wrote: > Signed-off-by: Francois Perrad > --- > package/luarocks/buildroot.lua | 60 ++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) I have applied this entire series, thanks! It's going in the good direction, but I found some odd things. The lpeg test looks like this: + self.module_test("lpeg", script="print(require[[lpeg]].version())") which clearly cannot have been generated by the Luarocks "buildroot" script, which does only: + f:write(' self.module_test("' .. modname .. '")\n') Also, I've used "lpeg-upgrade" and "rings-upgrade" as tests, and noticed some differences: - self.module_test("lpeg", script="print(require[[lpeg]].version())") + self.module_test("LPeg") So we have the difference I explained above + a difference in the casing of the module. We have the same casing difference with rings: - self.module_test("rings") + self.module_test("Rings") Is this expected ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com