From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/nfs-utils: making nfs server optional
Date: Thu, 28 Mar 2019 17:48:57 +0100 [thread overview]
Message-ID: <20190328174857.7c1d188e@windsurf> (raw)
In-Reply-To: <1553781189-15924-1-git-send-email-angelo@amarulasolutions.com>
Hello Angelo,
On Thu, 28 Mar 2019 14:53:09 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> +ifeq ($(BR2_PACKAGE_NFS_UTILS_SERVER),y)
> define NFS_UTILS_INSTALL_INIT_SYSV
> $(INSTALL) -D -m 0755 package/nfs-utils/S60nfs \
> $(TARGET_DIR)/etc/init.d/S60nfs
> @@ -95,6 +96,7 @@ define NFS_UTILS_INSTALL_INIT_SYSTEMD
> $(INSTALL) -D -m 0644 package/nfs-utils/nfs-utils_tmpfiles.conf \
> $(TARGET_DIR)/usr/lib/tmpfiles.d/nfs-utils.conf
> endef
> +endif
This is only removing the installation of the init script/systemd unit
files, not really disabling the server.
Shouldn't we do like BR2_PACKAGE_NFS_UTILS_RPCDEBUG,
BR2_PACKAGE_NFS_UTILS_RPC_LOCKD and BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD
are doing, and also remove the unnecessary programs ?
Another question is: the systemd stuff installs a nfs-client.service
unit file, and you're no longer installing this. It's named
nfs-client... so it seems to be needed even when you are just a client.
In fact, I think *some* of the daemons are needed even when you are
just a client. See what nfs-client.service is doing.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-28 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 13:53 [Buildroot] [PATCH v2] package/nfs-utils: making nfs server optional Angelo Compagnucci
2019-03-28 16:48 ` Thomas Petazzoni [this message]
2019-03-28 17:01 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328174857.7c1d188e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox