Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 0/2] add gettext-tiny package
Date: Sun, 31 Mar 2019 14:29:07 +0200	[thread overview]
Message-ID: <20190331142907.5b459037@windsurf> (raw)
In-Reply-To: <20190327230831.31468-1-vadim4j@gmail.com>

On Thu, 28 Mar 2019 01:08:29 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:

> Vadim Kochan (2):
>   package/gettext: turn into virtual package
>   package/gettext-tiny: new package

Thanks, I've applied both patches!

A couple of notes/suggestions:

 - It would be nice if you could work with upstream gettext-tiny to
   make sure gettext-tiny provides everything we need, without the need
   to bring some files from gettext-gnu.

 - The ecryptfs-utils package can probably see its BR2_USE_WCHAR
   dependency removed. Indeed, when BR2_SYSTEM_ENABLE_NLS is disabled,
   we use gettext-tiny, and wchar is no longer needed. And
   BR2_SYSTEM_ENABLE_NLS depends on wchar.

 - I have sent a patch for utils/genrandconfig that randomly sets BR2_SYSTEM_ENABLE_NLS=y in the autobuilder configurations, in order to test this situation.

> 
>  DEVELOPERS                                         |   1 +
>  package/Config.in                                  |   2 +
>  .../0001-error_print_progname.patch                |   0
>  .../0002-Update-after-gnulib-changed.patch         |   0
>  package/gettext-gnu/Config.in                      |  24 +++++
>  .../gettext.hash => gettext-gnu/gettext-gnu.hash}  |   0
>  package/gettext-gnu/gettext-gnu.mk                 | 103 +++++++++++++++++++
>  ...-format-not-a-string-literal-error-for-gc.patch |  55 ++++++++++
>  package/gettext-tiny/Config.in                     |  18 ++++
>  package/gettext-tiny/gettext-tiny.hash             |   5 +
>  package/gettext-tiny/gettext-tiny.mk               | 114 +++++++++++++++++++++
>  package/gettext-tiny/gettext-wrapper               |  24 +++++
>  package/gettext/Config.in                          |  25 ++---
>  package/gettext/gettext.mk                         |  96 +----------------
>  14 files changed, 357 insertions(+), 110 deletions(-)
>  rename package/{gettext => gettext-gnu}/0001-error_print_progname.patch (100%)
>  rename package/{gettext => gettext-gnu}/0002-Update-after-gnulib-changed.patch (100%)
>  create mode 100644 package/gettext-gnu/Config.in
>  rename package/{gettext/gettext.hash => gettext-gnu/gettext-gnu.hash} (100%)
>  create mode 100644 package/gettext-gnu/gettext-gnu.mk
>  create mode 100644 package/gettext-tiny/0001-libintl-Fix-format-not-a-string-literal-error-for-gc.patch
>  create mode 100644 package/gettext-tiny/Config.in
>  create mode 100644 package/gettext-tiny/gettext-tiny.hash
>  create mode 100644 package/gettext-tiny/gettext-tiny.mk
>  create mode 100644 package/gettext-tiny/gettext-wrapper
> 



-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-03-31 12:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 23:08 [Buildroot] [PATCH v4 0/2] add gettext-tiny package Vadim Kochan
2019-03-27 23:08 ` [Buildroot] [PATCH v4 1/2] package/gettext: turn into virtual package Vadim Kochan
2019-03-27 23:08 ` [Buildroot] [PATCH v4 2/2] package/gettext-tiny: new package Vadim Kochan
2019-03-31 12:29 ` Thomas Petazzoni [this message]
2019-03-31 12:30   ` [Buildroot] [PATCH v4 0/2] add gettext-tiny package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331142907.5b459037@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox